Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass peg revision when getting contents for diff #147

Merged
merged 1 commit into from
Jun 19, 2015

Conversation

selsemore
Copy link
Collaborator

When trying to display a diff from the review editor for a file that existed at the revision at which the patch was created but does not exist in the HEAD revision, the compare fails with a "filesystem has no item" error. This can be fixed by explicitly passing the peg revision when getting the contents in SubclipseSCMFileContentsLocator. This might be the source of the Issue 142 problem.

http://svnbook.red-bean.com/en/1.6/svn.advanced.pegrevs.html

"Note that even when you don't explicitly supply a peg revision or operative revision, they are still present. For your convenience, the default peg revision is BASE for working copy items and HEAD for repository URLs. And when no operative revision is provided, it defaults to being the same revision as the peg revision."

@rombert
Copy link
Owner

rombert commented Jun 19, 2015

Merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants