Pass peg revision when getting contents for diff #147
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to display a diff from the review editor for a file that existed at the revision at which the patch was created but does not exist in the HEAD revision, the compare fails with a "filesystem has no item" error. This can be fixed by explicitly passing the peg revision when getting the contents in SubclipseSCMFileContentsLocator. This might be the source of the Issue 142 problem.
http://svnbook.red-bean.com/en/1.6/svn.advanced.pegrevs.html
"Note that even when you don't explicitly supply a peg revision or operative revision, they are still present. For your convenience, the default peg revision is BASE for working copy items and HEAD for repository URLs. And when no operative revision is provided, it defaults to being the same revision as the peg revision."