chore(ci): Fix new lines in github output (#4542)

rome · May 30, 2023 · 4af8e57 · 4af8e57
1 parent 422eb7f
commit 4af8e57
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 20 deletions.
diff --git a/.github/workflows/bench_analyzer.yml b/.github/workflows/bench_analyzer.yml
@@ -62,11 +62,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/bench_formatter.yml b/.github/workflows/bench_formatter.yml
@@ -62,11 +62,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/bench_parser.yml b/.github/workflows/bench_parser.yml
@@ -61,11 +61,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/parser_conformance.yml b/.github/workflows/parser_conformance.yml
@@ -68,11 +68,10 @@ jobs:
           echo "## Parser conformance results on ${{ matrix.os }}" > output
           cargo coverage compare ./base_results.json ./new_results.json --markdown >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+
 
       - name: Get the PR number
         if: github.event_name == 'pull_request'