🐛 error: no bin target named rome_lsp

[lgarron]

I'm trying to follow https://github.com/rome/tools/blob/main/CONTRIBUTING.md#language-server-and-vs-code-extension-development so I can test #3089 and #3088 (without waiting a week).

Environment information

macOS 12.5.1
M1 Pro MacBook Pro

What happened?

git clone https://github.com/rome/tools
cd tools

cargo build --bin rome_lsp

Result:

error: no bin target named `rome_lsp`

Expected result

The instructions result in a rome_lsp binary.

Note that cargo build --bin rome works — it's only the rome_lsp target that fails for me.

Code of Conduct

• I agree to follow Rome's Code of Conduct

[lgarron]

It seems that rome_lsp might be a "lib" and not a "bin"?

tools/.github/workflows/release_lsp.yml

Line 105 in de04db1

run: cargo build -p rome_bin --release --target ${{ matrix.target }}

This works, but doesn't create a binary.

cargo build -p rome_bin --release

Taken from

[lgarron]

Okay, it looks like I should maybe actually use the rome binary path directly as rome.lspBin?

Unfortunately, installing both the built .vpix (which I had to do using the UI?) and setting rome.lspBin doesn't seem to have fixed #3088 (although #3089 no longer breaks).

[ematipico]

There's a PR to update that section. #3136

[ematipico]

Also, if you're now using the built binary, you can now inspect the logs: https://rome.github.io/tools/rome_bin/index.html#logs

[ematipico]

The section has been updated!