Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

chore: update contribution guidelines #3136

Merged
merged 2 commits into from
Aug 31, 2022
Merged

chore: update contribution guidelines #3136

merged 2 commits into from
Aug 31, 2022

Conversation

ematipico
Copy link
Contributor

Summary

Updated CONTRIBUTING.md with some guidelines around how the flow works for the Node.js APIs.

I also updated the LSP section, which was outdated. It has changed since we merged the daemon feature.

Test Plan

Just check the rendered result

@ematipico ematipico requested a review from a team August 30, 2022 12:09
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8d3d22
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Would it make sense to add a link to the Contributing file (right section) into the Readme of npm/rome? That was the first file I looked for instructions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit d8d3d22
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/630f69b614090400090ea2b8

@ematipico
Copy link
Contributor Author

Nit: Would it make sense to add a link to the Contributing file (right section) into the Readme of npm/rome? That was the first file I looked for instructions.

The link is under the community heading: https://github.com/rome/tools#community

@ematipico ematipico merged commit 255e783 into main Aug 31, 2022
@ematipico ematipico deleted the chore/contributing branch August 31, 2022 14:02
ematipico added a commit that referenced this pull request Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants