Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Parser: export default function in declare module #3485

Closed
1 task done
Boshen opened this issue Oct 26, 2022 · 1 comment · Fixed by #3775
Closed
1 task done

🐛 Parser: export default function in declare module #3485

Boshen opened this issue Oct 26, 2022 · 1 comment · Fixed by #3775
Assignees
@denbezrukov
Labels
A-Parser Area: parser S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@Boshen
Copy link
Contributor

Boshen commented Oct 26, 2022 •
edited
Loading

Environment information

PlayGround

What happened?

declare module 'x' {
  export default function (option: any): void
}

reports

✖ expected an identifier, an array pattern, or an object pattern but instead found '('

Expected result

It should parse without syntax error

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Parser Area: parser labels Oct 26, 2022
@denbezrukov
Copy link
Contributor

Could I try it?

@ematipico ematipico added this to the 11.0.0 milestone Nov 14, 2022
@denbezrukov denbezrukov mentioned this issue Nov 15, 2022
Closed
1 task
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
41fd2ee 
…3485
@denbezrukov denbezrukov mentioned this issue Nov 17, 2022
Merged
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
009c5b7 
…3485
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
c5238db 
…3485
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
9a6bbd4 
…3485
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
6a59be4 
…3485
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module rome#…
6f7ec45 
…3485
MichaReiser pushed a commit that referenced this issue Nov 17, 2022
@denbezrukov
feat(rome_js_parser): export default function in declare module #3485 (…
46f59a6 
…#3775)

Fix #3485
@MichaReiser MichaReiser moved this to Done in Rome 2022 Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denbezrukov denbezrukov

Labels
A-Parser Area: parser S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rome_js_parser): export default function in declare module #3485 denbezrukov/tools
4 participants
@ematipico @MichaReiser @Boshen @denbezrukov