This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve the detection of ReactDOM.render calls in noRenderReturnValue
#3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
MichaReiser
approved these changes
Nov 9, 2022
…s in `noRenderReturnValue`
leops
force-pushed
the
fix/no-render-return-value
branch
from
14e7c29 to
e1039ae
Compare
Good catch, I did add it originally but it got lost when I split out the single test files into multiple modules |
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 10, 2022
* upstream/main: fix(npm/js-api): Import type from @rometools/backend-jsonrpc (rome#3647) doc(npm/js-api): Add experimental warning to README fix(npm/js-api): Lazy load backend implementations (rome#3652) feat(rome_lsp): stop the daemon after the last client disconnects (rome#3643) fix(npm/js_api): Ensure JS API build contains `dist` folder (rome#3648) fix(rome_cli): ensures the service only connects to compatible versions (rome#3642) feat(playground): add settings button and group IR (rome#3559) release: v10.0.1 (rome#3649) fix(rome_js_analyze): False positives for interactive elements in `useKeyWithClickEvents` (rome#3644) fix(rome_js_semantic): support for object and array bindings when exporting (rome#3620) doc(editors): Clarify Rome discovery (rome#3639) fix(rome_js_analyze): improve the detection of `ReactDOM.render` calls in `noRenderReturnValue` (rome#3626) chore(npm): add license (rome#3629) Add rustdocs index Add environment Change rust docs to use Netlify fix(rome_js_analyze): useValidAnchor considering all possible expressions (rome#3599) fix(rome_js_formatter): Trailing comma inside import rome#3600 (rome#3624)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3617
This refactors the
noRenderReturnValuerule to useis_react_call_apito detect calls toReactDOM.render. This includes extendingis_react_call_apito support detecting symbols imported fromreact-domin addition to thereactpackage.Test Plan
I've extended the tests for the
noRenderReturnValueto have cases with and without an import statement, and check for regressions of the false positive case described in #3617