This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(vscode): try to resolve the rome package from the workspace root #3717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3635
This PR makes use of the
resolve
library to resolve the corresponding@rometools/cli-*
package for the current platform from each workspace root folder. This lets the extension automatically detect and use the correct version of the language server if the workspace has an explicit dependency on therome
packageTest Plan
I built and installed the extension locally, opened a test workspace with the
rome
package installed, and checked the extension is correctly using the version of Rome loaded from npm instead of its own bundled binary