Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(vscode): try to resolve the rome package from the workspace root #3717

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

leops
Copy link
Contributor

@leops leops commented Nov 14, 2022

Summary

Fixes #3635

This PR makes use of the resolve library to resolve the corresponding @rometools/cli-* package for the current platform from each workspace root folder. This lets the extension automatically detect and use the correct version of the language server if the workspace has an explicit dependency on the rome package

Test Plan

I built and installed the extension locally, opened a test workspace with the rome package installed, and checked the extension is correctly using the version of Rome loaded from npm instead of its own bundled binary

@leops leops requested a review from a team November 14, 2022 10:08
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 7870a87
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637244e323468f00099e8ba5
😎 Deploy Preview https://deploy-preview-3717--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MichaReiser
Copy link
Contributor

MichaReiser commented Nov 14, 2022

Please update the editor README to explain how the Rome binary is resolved.

@ematipico ematipico added E-VScode Editors: VSCode A-Editors Area: editors labels Nov 14, 2022
@leops leops merged commit 18594f5 into main Nov 14, 2022
@leops leops deleted the feature/vscode-workspace-resolve branch November 14, 2022 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Editors Area: editors E-VScode Editors: VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 VS Extension: Resolve rome binary from workspace
3 participants