Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

script to analyze behaviour of rome throughout time #3885

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 28, 2022

Summary

Small script to help to understand what changed through time. It will checkout, build and run rome for each commit specified and will generate a report like the one below.

Example

1 - feat(rome_js_semantic): model improvements (#3825)

Details

  • semantic model improvements

2022-11-23 11:18:13 +0000

Result

Checked 1 file(s) in 609µs

2 - feat(rome_js_analyze): promote rules (#3471)

Details

2022-11-01 08:20:00 +0000

Result

Checked 1 files in 668µs

3 - feat(rome_js_analyze): handle serde errors inside RuleContext (#3352)

Details

2022-10-10 16:39:56 +0100

Result

/home/user/github/test.ts:1:7 lint/nursery/noUnusedVariables ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × This variable is unused.
  
  > 1 │ const a = <T>(a: T) => console.log(a);
      │       ^
  
  i Unused variables usually are result of incomplete refactoring, typos and other source of bugs.
  

Checked 1 files in 956µs
Error: errors where emitted while running checks

4 - perf(rome_js_analyze): improve the performance of noUndeclaredVariables (#3320)

Details

  • perf(rome_js_analyze): improve the performance of noUndeclaredVariables by allowing it to directly inspect the semantic model

  • address PR review

  • PR review and tests improvements

2022-10-05 10:50:24 +0200

Result

/home/user/github/test.ts:1:7 lint/nursery/noUnusedVariables ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × This variable is unused.
  
  > 1 │ const a = <T>(a: T) => console.log(a);
      │       ^
  
  i Unused variables usually are result of incomplete refactoring, typos and other source of bugs.
  

Checked 1 files in 767µs
Error: errors where emitted while running checks

5 - refactor(rome_analyze): automatically derive the rule category in declare_rule! (#3321)

Details

  • automatically derive the rule category in declare_rule!

  • link the rules to their group and category at the type system level

  • fixup after rebase

  • run codegen

  • Update crates/rome_analyze/src/rule.rs

2022-10-05 09:43:08 +0200

Result

/home/user/github/test.ts:1:7 lint/nursery/noUnusedVariables ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × This variable is unused.
  
  > 1 │ const a = <T>(a: T) => console.log(a);
      │       ^
  
  i Unused variables usually are result of incomplete refactoring, typos and other source of bugs.
  

Checked 1 files in 484µs
Error: errors where emitted while running checks

Performance

Command Mean [ms] Min [ms] Max [ms] Relative
1 3.0 ± 0.7 2.4 18.9 3.15 ± 0.90
2 2.3 ± 0.4 1.7 6.9 2.41 ± 0.57
3 1.0 ± 0.1 0.7 2.0 1.00 ± 0.22
4 1.0 ± 0.2 0.7 2.5 1.00 ± 0.24
5 1.0 ± 0.2 0.7 2.1 1.00

whisker

@xunilrj xunilrj requested a review from a team as a code owner November 28, 2022 16:05
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit a825575
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6384dc58c20c8b0008a1ced7
😎 Deploy Preview https://deploy-preview-3885--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@xunilrj xunilrj merged commit 8d3fe0b into main Nov 28, 2022
@xunilrj xunilrj deleted the chore/rome-timetravel branch November 28, 2022 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants