Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): complete useAriaPropTypes rule #3959

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Dec 5, 2022

Summary

Closes #3886
Closes #3949

This PR completes the rule useAriaPropTypes, the rule uses the completed rome_aria metadata and adds more test cases (taken from the old rule). It adds the handling of some cases: empty strings and empty template literals.

I took the opportunity to move the code generation of the metadata inside the build.rs script, but in order to avail of it, I had to create a new crate called rome_aria_metadata where these data are stored and then consumed by rome_aria crate.

Test Plan

I added new test cases to the rule.

@ematipico ematipico requested review from leops, xunilrj and a team as code owners December 5, 2022 17:12
@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit ec44b24
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6393489c8813790008fea147
😎 Deploy Preview https://deploy-preview-3959--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico force-pushed the feat/full-aria-props branch from 55da22a to 4677589 Compare December 7, 2022 08:55
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1684 1684 0
Failed 4262 4262 0
Panics 0 0 0
Coverage 28.32% 28.32% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

@ematipico ematipico force-pushed the feat/full-aria-props branch from 4677589 to b3185fd Compare December 7, 2022 09:08
@ematipico ematipico force-pushed the feat/full-aria-props branch from eae3d96 to 462ef3e Compare December 8, 2022 11:44
@ematipico ematipico requested a review from leops December 8, 2022 11:44
@ematipico ematipico requested a review from xunilrj December 8, 2022 13:39
@ematipico ematipico merged commit 7ba67ce into main Dec 9, 2022
@ematipico ematipico deleted the feat/full-aria-props branch December 9, 2022 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add to rome_aria metadata for ARIA attributes useAriaPropTypes
3 participants