This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 656
feat(rome_js_analyze): complete useAriaPropTypes
rule
#3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
force-pushed
the
feat/full-aria-props
branch
from
December 7, 2022 08:55
55da22a
to
4677589
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
force-pushed
the
feat/full-aria-props
branch
from
December 7, 2022 09:08
4677589
to
b3185fd
Compare
leops
reviewed
Dec 8, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/nursery/useAriaPropTypes/invalid.jsx.snap
Outdated
Show resolved
Hide resolved
ematipico
force-pushed
the
feat/full-aria-props
branch
from
December 8, 2022 11:44
eae3d96
to
462ef3e
Compare
xunilrj
reviewed
Dec 8, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 8, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
leops
approved these changes
Dec 9, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_prop_types.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3886
Closes #3949
This PR completes the rule
useAriaPropTypes
, the rule uses the completedrome_aria
metadata and adds more test cases (taken from the old rule). It adds the handling of some cases: empty strings and empty template literals.I took the opportunity to move the code generation of the metadata inside the
build.rs
script, but in order to avail of it, I had to create a new crate calledrome_aria_metadata
where these data are stored and then consumed byrome_aria
crate.Test Plan
I added new test cases to the rule.