Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_parser): support property init in ambient context (node) #4225

Merged
merged 1 commit into from
Feb 22, 2023
Merged

feat(rome_js_parser): support property init in ambient context (node) #4225

merged 1 commit into from
Feb 22, 2023

Conversation

Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Feb 21, 2023

Summary

Fixes #2958

In contrast to #4219, this PR introduces a new node.

Test Plan

Parser and formatter tests included.

Documentation

No change

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 73cba41
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63f52febfe4028000831ccf3

@Conaclos Conaclos changed the title feat(rome_js_parser): support property init in ambient context (new n… feat(rome_js_parser): support property init in ambient context (node) Feb 21, 2023
@ematipico
Copy link
Contributor

Thank you for doing this! I prefer this approach!

@ematipico ematipico added this pull request to the merge queue Feb 22, 2023
Merged via the queue into rome:main with commit 62c7738 Feb 22, 2023
@Conaclos Conaclos deleted the rome_js_parser/alt/2958 branch March 7, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Parser: Initializers should be allowed for ambientreadonly in TsPropertySignatureClassMember
2 participants