This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
Revert "feat(rome_js_parser, rome_js_formatter): import attribute (#4359)" #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
github-actions
bot
added
A-Formatter
Area: formatter
A-Parser
Area: parser
A-Tooling
Area: our own build, development, and release tooling
labels
May 17, 2023
ematipico
force-pushed
the
revert/import-attribute
branch
from
May 17, 2023 11:59
a7be89a
to
3a3d39e
Compare
ematipico
changed the title
Revert "feat(rome_js_parser, rome_js_formatter): import attribute (#4…
Revert "feat(rome_js_parser, rome_js_formatter): import attribute (#4359)"
May 17, 2023
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
@denbezrukov @Conaclos should we revert the change in the grammar and wait for the major tools first? |
)" This reverts commit 0f04d8c.
ematipico
force-pushed
the
revert/import-attribute
branch
from
May 23, 2023 13:44
22ba3c9
to
48ba862
Compare
ematipico
force-pushed
the
revert/import-attribute
branch
from
May 23, 2023 13:51
48ba862
to
fe41cd5
Compare
I have no strong opinions about this. I am wondering: could we support both for transitional purpose? |
I will update the PR with both grammars |
ematipico
force-pushed
the
revert/import-attribute
branch
from
May 30, 2023 08:57
756606d
to
e2fca94
Compare
@rome/core-contributors Please check my latest commit. I decided to keep the change to a minimum, without adding new nodes and changes to the semantics. I think as a temporary solution it could work until we will change to the new grammar for good. What do you think? |
ematipico
force-pushed
the
revert/import-attribute
branch
from
May 30, 2023 09:06
e2fca94
to
4eaea6d
Compare
Look good to me👍🏽👍🏽 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Formatter
Area: formatter
A-Parser
Area: parser
A-Tooling
Area: our own build, development, and release tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f04d8c.
Summary
Test Plan
Changelog
Documentation