Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.0 #1061

Merged
merged 86 commits into from
Aug 7, 2024
Merged

v3.4.0 #1061

merged 86 commits into from
Aug 7, 2024

Commits on Jul 21, 2024

  1. misc: Add Redis async cache

    Introduce an asynchronous Redis instance to be used in async functions.
    Also, this change migrates most of the sync cache usage to the new async
    cache.
    adamantike committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    6eb8e6a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge pull request #1010 from rommapp/misc/add-async-cache

    misc: Add Redis async cache
    adamantike authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e1cec57 View commit details
    Browse the repository at this point in the history
  2. misc: Migrate MobyGamesHandler to async

    Convert `MobyGamesHandler` methods to be asynchronous, and use an
    `httpx` async client, instead of `requests` sync client.
    adamantike committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6d8a871 View commit details
    Browse the repository at this point in the history
  3. Create config.batocera-retrobat.yml

    Creates an example config file for Batocera/RetroBat-based mappings, as popular distributions so should hopefully save people a few hours.
    
    Tested with a setup using RetroBat v6.0.3 folder structures, and only keeping matches for which I'm certain.
    TyroneSlothrop authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    bb01cf6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52a9605 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1013 from TyroneSlothrop/patch-1

    Create config.batocera-retrobat.yml
    gantoine authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    634e68e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    7c6dfa8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1011 from rommapp/misc/migrate-moby-handler-to-async

    misc: Migrate MobyGamesHandler to async
    adamantike authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b9da728 View commit details
    Browse the repository at this point in the history
  3. Update config.batocera-retrobat.yml

    Updates after discovering all the extra cool icons already available (but not advertised in supported platforms!) and sorting.
    TyroneSlothrop authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cfd2e12 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge pull request #1016 from TyroneSlothrop/patch-2

    Update config.batocera-retrobat.yml
    gantoine authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c81fe52 View commit details
    Browse the repository at this point in the history
  2. misc: Migrate filesystem resource handler to async

    For filesystem resource handler, `requests` calls have been replaced
    with `httpx`, and file I/O has been replaced with `anyio` utils.
    
    The existing approach to save covers and screenshots, by calling
    `shutil.copyfileobj` with the raw response is no longer needed. `httpx`
    does not provide a file-like object when streaming [1], so there's no
    easy drop-in replacement.
    
    However, the applied solution correctly builds the file iteratively, by
    consuming the response in chunks.
    
    [1] encode/httpx#2296
    adamantike committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    56066d6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1017 from rommapp/misc/migrate-filesystem-resourc…

    …e-handler-to-async
    
    misc: Migrate filesystem resource handler to async
    adamantike authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    158b16c View commit details
    Browse the repository at this point in the history
  4. misc: Replace pytest-vcr dependency with pytest-recording

    `pytest-vcr` [1] is no longer maintained (last commit was in 2020), and
    `VCR.py` recommends [2] `pytest-recording` instead.
    
    Also, `pytest-vcr` does not correctly support `httpx` [3].
    
    This change also removes unused cassettes.
    
    [1] https://github.com/ktosiek/pytest-vcr
    [2] https://vcrpy.readthedocs.io/en/latest/usage.html#pytest-integration
    [3] ktosiek/pytest-vcr#46
    adamantike committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    959e896 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1021 from rommapp/misc/replace-pytest-vcr-with-py…

    …test-recording
    
    misc: Replace pytest-vcr dependency with pytest-recording
    gantoine authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e7e37f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. misc: Refactor scan process by splitting single function

    This change mainly refactors the `scan_platforms` function, moving part
    of its logic to `_identify_platform`, `_identify_firmware`, and
    `_identify_rom`.
    
    The logic is simpler this way, each smaller function returns `ScanStats`
    that can be merged by the caller, and it simplifies future performance
    improvements.
    adamantike committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2bfc3c4 View commit details
    Browse the repository at this point in the history
  2. start making collecitons public

    Georges-Antoine Assi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    92b2365 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1024 from rommapp/misc/refactor-scan-process

    misc: Refactor scan process by splitting single function
    adamantike authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    377d460 View commit details
    Browse the repository at this point in the history
  4. [ROMM-1025] Replace game-and-watch with g-and-w

    Georges-Antoine Assi authored and gantoine committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7555c06 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    38a500f View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1026 from rommapp/romm-1025

    [ROMM-1025] Replace game-and-watch with g-and-w
    gantoine authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    fafd485 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ad3a588 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge pull request #1028 from rommapp/share-public-collections

    Public collections
    gantoine authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    141edf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. misc: Migrate IGDBBaseHandler to async

    Convert `IGDBBaseHandler` methods to be asynchronous, and use an `httpx`
    async client, instead of `requests` sync client.
    
    This change also removes the direct dependency with `requests`, as the
    project no longer uses it, preferring `httpx` instead.
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    aced1f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96699a2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1023 from rommapp/misc/migrate-igdb-handler-to-async

    misc: Migrate IGDBBaseHandler to async
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    146c26c View commit details
    Browse the repository at this point in the history
  4. fix: Enable flake8-async rules in ruff and fix warnings

    `ASYNC` rules [1] tries to find issues regarding asynchronous code. This
    change enables `ruff` to start reporting these issues, and fixes
    existing warnings.
    
    [1] https://docs.astral.sh/ruff/rules/#flake8-async-async
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c5b150c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1fda90 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1030 from rommapp/fix/enable-async-rules-ruff

    fix: Enable flake8-async rules in ruff and fix warnings
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9b52a4b View commit details
    Browse the repository at this point in the history
  7. fix: Return early if IGDB finds an exact match

    This improvement avoids extra IGDB API requests when a received Rom is
    an exact match. It avoids up to 2 requests per Rom, when an exact match
    is found.
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9319081 View commit details
    Browse the repository at this point in the history
  8. fix: Initialize context on scheduled task

    Only for this scheduled task, the run was failing because there was no
    context initialization that created the httpx session.
    
    Other schedules work as expected, because they do have context
    initialization in the functions they call to (e.g. `scan_platforms`).
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    fe5759f View commit details
    Browse the repository at this point in the history
  9. Merge pull request #1033 from rommapp/fix/scheduled-switch-title-db-run

    fix: Initialize context on scheduled task
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    66f4c0a View commit details
    Browse the repository at this point in the history
  10. Merge pull request #1032 from rommapp/fix/quick-return-if-igdb-exact-…

    …match
    
    fix: Return early if IGDB finds an exact match
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9246f87 View commit details
    Browse the repository at this point in the history
  11. misc: Use PYTEST_VERSION variable to detect Pytest runs

    Pytest v8.2 introduced the `PYTEST_VERSION` environment variable [1],
    that can be used to check if code is running from within a pytest run.
    
    This way, we can avoid checking the loaded `sys` modules.
    
    [1] https://docs.pytest.org/en/stable/changelog.html#id57
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    749e4d6 View commit details
    Browse the repository at this point in the history
  12. Merge pull request #1034 from rommapp/misc/use-PYTEST_VERSION-to-dete…

    …ct-pytest-runs
    
    misc: Use PYTEST_VERSION variable to detect Pytest runs
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    33e6c23 View commit details
    Browse the repository at this point in the history
  13. misc: Use async interface for stream-zip

    Replace use of synchronous `stream_zip` implementation, with
    `async_stream_zip`. [1]
    
    [1] https://stream-zip.docs.trade.gov.uk/async-interface/
    adamantike committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    16cb380 View commit details
    Browse the repository at this point in the history
  14. Merge pull request #1035 from rommapp/misc/use-async-stream-zip

    misc: Use async interface for stream-zip
    adamantike authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    05a85d5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8e3ae30 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    1e33d18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30a6ec3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b487c2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1037 from rommapp/romm-1029

    [ROMM-1029] Store and re-use last saved biois/save/state/core
    gantoine authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    de2ac3d View commit details
    Browse the repository at this point in the history
  5. Added additional platform icons

    More to come!
    Casuallynoted authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    0759985 View commit details
    Browse the repository at this point in the history
  6. Update ATTRIBUTIONS

    Casuallynoted authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    514fc9b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c34f147 View commit details
    Browse the repository at this point in the history
  8. Delete frontend/assets/platforms/palm-os.ico

    I have better ideas of what to do with this one. Since with previous mobile platforms, I've had an example phone with the logo on the screen, I want to do that for Palm as well. May also come back at some point and do that for J2ME if I have time but I think with that one, the java logo works as a platform icon for now. Here, I'm less certain.
    Casuallynoted authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d136807 View commit details
    Browse the repository at this point in the history
  9. Add files via upload

    Casuallynoted authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ebfd9dd View commit details
    Browse the repository at this point in the history
  10. Merge pull request #1038 from Casuallynoted/master

    Additional platform icons again!
    gantoine authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    352fd95 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    49296aa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    77ba874 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    29bb08e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1042 from rommapp/romm-1018

    [ROMM-1018] Fix scanning selected roms
    gantoine authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1e1d856 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1041 from rommapp/romm-1020

    [ROMM-1020] Fix firmware pagination on mount
    gantoine authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    05de165 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6941514 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fce451a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48bdfb9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #1045 from rommapp/hotfix-related-games

    Hotfix and link from related games
    gantoine authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    535cb5a View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Fix incorrectly converted platform icons

    Hotfix for the previously submitted additional icons. Corrects low res/white background issue.
    Casuallynoted authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1e58417 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1046 from Casuallynoted/master

    Fix incorrectly converted platform icons
    gantoine authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    072fc9e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Add missing space

    HellLord77 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    697723a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1048 from HellLord77/fix-typo

    Fix tyo in feontend
    gantoine authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9f7058d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8cd4cf1 View commit details
    Browse the repository at this point in the history
  4. try fix ignore generated

    gantoine committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c77ca88 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Merge pull request #1044 from rommapp/romm-1012

    [ROMM-1012] Fix multi-file download in gakllery view
    gantoine authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    ebd0c07 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Configuration menu
    Copy the full SHA
    eba529b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1036 from rommapp/romm-1031

    [ROMM-1031] Remove persistent overlay prevents back navigation
    gantoine authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    f437bac View commit details
    Browse the repository at this point in the history
  3. Update frontend/src/components/Details/Info/GameInfo.vue

    Co-authored-by: Zurdi <34356590+zurdi15@users.noreply.github.com>
    gantoine and zurdi15 authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    6d366aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d6b96b View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1040 from rommapp/romm-1019

    [ROMM-1019] Clickable filter buttons on details view
    gantoine authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    ed96603 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1043 from rommapp/romm-1022

    [ROMM-1022] Add button to show duplicates
    gantoine authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    b06b0f4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    32823af View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1054 from rommapp/romm-1052

    Added link to home button
    gantoine authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    7e52b50 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    ebe570d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1055 from rommapp/type-fix-additional-content

    Add workflow that runs typecheck on PRs
    gantoine authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9b4206a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9a68ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    02cf0fd View commit details
    Browse the repository at this point in the history
  5. fix: Backend URL redirection logic

    Fix FastAPI and nginx configuration, to make the application correctly
    redirect URLs. This is specially useful when URLs ended with forward
    slash are redirected to their stripped version.
    
    Included changes:
    * Stop removing the `/api` prefix in nginx rewrite rules, so FastAPI
      knows what's the original URL path being requested.
    * Use `$http_host` in nginx, so FastAPI receives both the original host
      and port, to build the redirect URL (as `$host` does not include the
      port, if present).
    * Make all FastAPI included routers know their prefix, to correctly
      route incoming requests.
    
    This fix was found based on a report that redirects from URLs ended with
    forward slash were not working [1].
    
    [1] #1051 (comment)
    adamantike committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    45aeaf3 View commit details
    Browse the repository at this point in the history
  6. update vite config

    gantoine committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    805a688 View commit details
    Browse the repository at this point in the history
  7. fix endpoint tests

    gantoine committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a53c091 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d17cdd6 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #1058 from rommapp/fix/fastapi-redirections

    fix: Backend URL redirection logic
    adamantike authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    cbab9f6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ada7f5f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge pull request #1057 from rommapp/fix/csrf-token

    Fix CSRF token issues
    gantoine authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    76d6798 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. misc: Make backend handle URLs with trailing slash

    According to multiple FastAPI discussions [1], FastAPI only includes a
    built-in mechanism to redirect requests including a trailing slash, to
    its variation without slash, using a `307` status code.
    
    This can be an issue when certain clients do not send the same headers
    on the redirected request.
    
    This change adds a custom FastAPI `APIRouter`, that registers both route
    path variations (with and without trailing slash), while only marking
    the path without slash for being included in the OpenAPI schema.
    
    [1] fastapi/fastapi#7298
    adamantike committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8abbae4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1059 from rommapp/misc/backend-handle-trailing-slash

    misc: Make backend handle URLs with trailing slash
    adamantike authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5e17efc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbeac18 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1060 from rommapp/drop-auth-user-pass

    Drop ROMM_AUTH_USERNAME and ROMM_AUTH_PASSWORD env variables
    gantoine authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    51ee99e View commit details
    Browse the repository at this point in the history