-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.4.0 #1061
Commits on Jul 21, 2024
-
Introduce an asynchronous Redis instance to be used in async functions. Also, this change migrates most of the sync cache usage to the new async cache.
Configuration menu - View commit details
-
Copy full SHA for 6eb8e6a - Browse repository at this point
Copy the full SHA 6eb8e6aView commit details
Commits on Jul 22, 2024
-
Merge pull request #1010 from rommapp/misc/add-async-cache
misc: Add Redis async cache
Configuration menu - View commit details
-
Copy full SHA for e1cec57 - Browse repository at this point
Copy the full SHA e1cec57View commit details -
misc: Migrate MobyGamesHandler to async
Convert `MobyGamesHandler` methods to be asynchronous, and use an `httpx` async client, instead of `requests` sync client.
Configuration menu - View commit details
-
Copy full SHA for 6d8a871 - Browse repository at this point
Copy the full SHA 6d8a871View commit details -
Create config.batocera-retrobat.yml
Creates an example config file for Batocera/RetroBat-based mappings, as popular distributions so should hopefully save people a few hours. Tested with a setup using RetroBat v6.0.3 folder structures, and only keeping matches for which I'm certain.
Configuration menu - View commit details
-
Copy full SHA for bb01cf6 - Browse repository at this point
Copy the full SHA bb01cf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52a9605 - Browse repository at this point
Copy the full SHA 52a9605View commit details -
Merge pull request #1013 from TyroneSlothrop/patch-1
Create config.batocera-retrobat.yml
Configuration menu - View commit details
-
Copy full SHA for 634e68e - Browse repository at this point
Copy the full SHA 634e68eView commit details
Commits on Jul 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c6dfa8 - Browse repository at this point
Copy the full SHA 7c6dfa8View commit details -
Merge pull request #1011 from rommapp/misc/migrate-moby-handler-to-async
misc: Migrate MobyGamesHandler to async
Configuration menu - View commit details
-
Copy full SHA for b9da728 - Browse repository at this point
Copy the full SHA b9da728View commit details -
Update config.batocera-retrobat.yml
Updates after discovering all the extra cool icons already available (but not advertised in supported platforms!) and sorting.
Configuration menu - View commit details
-
Copy full SHA for cfd2e12 - Browse repository at this point
Copy the full SHA cfd2e12View commit details
Commits on Jul 24, 2024
-
Merge pull request #1016 from TyroneSlothrop/patch-2
Update config.batocera-retrobat.yml
Configuration menu - View commit details
-
Copy full SHA for c81fe52 - Browse repository at this point
Copy the full SHA c81fe52View commit details -
misc: Migrate filesystem resource handler to async
For filesystem resource handler, `requests` calls have been replaced with `httpx`, and file I/O has been replaced with `anyio` utils. The existing approach to save covers and screenshots, by calling `shutil.copyfileobj` with the raw response is no longer needed. `httpx` does not provide a file-like object when streaming [1], so there's no easy drop-in replacement. However, the applied solution correctly builds the file iteratively, by consuming the response in chunks. [1] encode/httpx#2296
Configuration menu - View commit details
-
Copy full SHA for 56066d6 - Browse repository at this point
Copy the full SHA 56066d6View commit details -
Merge pull request #1017 from rommapp/misc/migrate-filesystem-resourc…
…e-handler-to-async misc: Migrate filesystem resource handler to async
Configuration menu - View commit details
-
Copy full SHA for 158b16c - Browse repository at this point
Copy the full SHA 158b16cView commit details -
misc: Replace pytest-vcr dependency with pytest-recording
`pytest-vcr` [1] is no longer maintained (last commit was in 2020), and `VCR.py` recommends [2] `pytest-recording` instead. Also, `pytest-vcr` does not correctly support `httpx` [3]. This change also removes unused cassettes. [1] https://github.com/ktosiek/pytest-vcr [2] https://vcrpy.readthedocs.io/en/latest/usage.html#pytest-integration [3] ktosiek/pytest-vcr#46
Configuration menu - View commit details
-
Copy full SHA for 959e896 - Browse repository at this point
Copy the full SHA 959e896View commit details -
Merge pull request #1021 from rommapp/misc/replace-pytest-vcr-with-py…
…test-recording misc: Replace pytest-vcr dependency with pytest-recording
Configuration menu - View commit details
-
Copy full SHA for e7e37f4 - Browse repository at this point
Copy the full SHA e7e37f4View commit details
Commits on Jul 25, 2024
-
misc: Refactor scan process by splitting single function
This change mainly refactors the `scan_platforms` function, moving part of its logic to `_identify_platform`, `_identify_firmware`, and `_identify_rom`. The logic is simpler this way, each smaller function returns `ScanStats` that can be merged by the caller, and it simplifies future performance improvements.
Configuration menu - View commit details
-
Copy full SHA for 2bfc3c4 - Browse repository at this point
Copy the full SHA 2bfc3c4View commit details -
start making collecitons public
Georges-Antoine Assi committedJul 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 92b2365 - Browse repository at this point
Copy the full SHA 92b2365View commit details -
Merge pull request #1024 from rommapp/misc/refactor-scan-process
misc: Refactor scan process by splitting single function
Configuration menu - View commit details
-
Copy full SHA for 377d460 - Browse repository at this point
Copy the full SHA 377d460View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7555c06 - Browse repository at this point
Copy the full SHA 7555c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a500f - Browse repository at this point
Copy the full SHA 38a500fView commit details -
Merge pull request #1026 from rommapp/romm-1025
[ROMM-1025] Replace game-and-watch with g-and-w
Configuration menu - View commit details
-
Copy full SHA for fafd485 - Browse repository at this point
Copy the full SHA fafd485View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad3a588 - Browse repository at this point
Copy the full SHA ad3a588View commit details
Commits on Jul 26, 2024
-
Merge pull request #1028 from rommapp/share-public-collections
Public collections
Configuration menu - View commit details
-
Copy full SHA for 141edf9 - Browse repository at this point
Copy the full SHA 141edf9View commit details
Commits on Jul 27, 2024
-
misc: Migrate IGDBBaseHandler to async
Convert `IGDBBaseHandler` methods to be asynchronous, and use an `httpx` async client, instead of `requests` sync client. This change also removes the direct dependency with `requests`, as the project no longer uses it, preferring `httpx` instead.
Configuration menu - View commit details
-
Copy full SHA for aced1f1 - Browse repository at this point
Copy the full SHA aced1f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96699a2 - Browse repository at this point
Copy the full SHA 96699a2View commit details -
Merge pull request #1023 from rommapp/misc/migrate-igdb-handler-to-async
misc: Migrate IGDBBaseHandler to async
Configuration menu - View commit details
-
Copy full SHA for 146c26c - Browse repository at this point
Copy the full SHA 146c26cView commit details -
fix: Enable flake8-async rules in ruff and fix warnings
`ASYNC` rules [1] tries to find issues regarding asynchronous code. This change enables `ruff` to start reporting these issues, and fixes existing warnings. [1] https://docs.astral.sh/ruff/rules/#flake8-async-async
Configuration menu - View commit details
-
Copy full SHA for c5b150c - Browse repository at this point
Copy the full SHA c5b150cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1fda90 - Browse repository at this point
Copy the full SHA d1fda90View commit details -
Merge pull request #1030 from rommapp/fix/enable-async-rules-ruff
fix: Enable flake8-async rules in ruff and fix warnings
Configuration menu - View commit details
-
Copy full SHA for 9b52a4b - Browse repository at this point
Copy the full SHA 9b52a4bView commit details -
fix: Return early if IGDB finds an exact match
This improvement avoids extra IGDB API requests when a received Rom is an exact match. It avoids up to 2 requests per Rom, when an exact match is found.
Configuration menu - View commit details
-
Copy full SHA for 9319081 - Browse repository at this point
Copy the full SHA 9319081View commit details -
fix: Initialize context on scheduled task
Only for this scheduled task, the run was failing because there was no context initialization that created the httpx session. Other schedules work as expected, because they do have context initialization in the functions they call to (e.g. `scan_platforms`).
Configuration menu - View commit details
-
Copy full SHA for fe5759f - Browse repository at this point
Copy the full SHA fe5759fView commit details -
Merge pull request #1033 from rommapp/fix/scheduled-switch-title-db-run
fix: Initialize context on scheduled task
Configuration menu - View commit details
-
Copy full SHA for 66f4c0a - Browse repository at this point
Copy the full SHA 66f4c0aView commit details -
Merge pull request #1032 from rommapp/fix/quick-return-if-igdb-exact-…
…match fix: Return early if IGDB finds an exact match
Configuration menu - View commit details
-
Copy full SHA for 9246f87 - Browse repository at this point
Copy the full SHA 9246f87View commit details -
misc: Use PYTEST_VERSION variable to detect Pytest runs
Pytest v8.2 introduced the `PYTEST_VERSION` environment variable [1], that can be used to check if code is running from within a pytest run. This way, we can avoid checking the loaded `sys` modules. [1] https://docs.pytest.org/en/stable/changelog.html#id57
Configuration menu - View commit details
-
Copy full SHA for 749e4d6 - Browse repository at this point
Copy the full SHA 749e4d6View commit details -
Merge pull request #1034 from rommapp/misc/use-PYTEST_VERSION-to-dete…
…ct-pytest-runs misc: Use PYTEST_VERSION variable to detect Pytest runs
Configuration menu - View commit details
-
Copy full SHA for 33e6c23 - Browse repository at this point
Copy the full SHA 33e6c23View commit details -
misc: Use async interface for stream-zip
Replace use of synchronous `stream_zip` implementation, with `async_stream_zip`. [1] [1] https://stream-zip.docs.trade.gov.uk/async-interface/
Configuration menu - View commit details
-
Copy full SHA for 16cb380 - Browse repository at this point
Copy the full SHA 16cb380View commit details -
Merge pull request #1035 from rommapp/misc/use-async-stream-zip
misc: Use async interface for stream-zip
Configuration menu - View commit details
-
Copy full SHA for 05a85d5 - Browse repository at this point
Copy the full SHA 05a85d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e3ae30 - Browse repository at this point
Copy the full SHA 8e3ae30View commit details
Commits on Jul 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e33d18 - Browse repository at this point
Copy the full SHA 1e33d18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a6ec3 - Browse repository at this point
Copy the full SHA 30a6ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b487c2 - Browse repository at this point
Copy the full SHA 4b487c2View commit details -
Merge pull request #1037 from rommapp/romm-1029
[ROMM-1029] Store and re-use last saved biois/save/state/core
Configuration menu - View commit details
-
Copy full SHA for de2ac3d - Browse repository at this point
Copy the full SHA de2ac3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0759985 - Browse repository at this point
Copy the full SHA 0759985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 514fc9b - Browse repository at this point
Copy the full SHA 514fc9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c34f147 - Browse repository at this point
Copy the full SHA c34f147View commit details -
Delete frontend/assets/platforms/palm-os.ico
I have better ideas of what to do with this one. Since with previous mobile platforms, I've had an example phone with the logo on the screen, I want to do that for Palm as well. May also come back at some point and do that for J2ME if I have time but I think with that one, the java logo works as a platform icon for now. Here, I'm less certain.
Configuration menu - View commit details
-
Copy full SHA for d136807 - Browse repository at this point
Copy the full SHA d136807View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebfd9dd - Browse repository at this point
Copy the full SHA ebfd9ddView commit details -
Merge pull request #1038 from Casuallynoted/master
Additional platform icons again!
Configuration menu - View commit details
-
Copy full SHA for 352fd95 - Browse repository at this point
Copy the full SHA 352fd95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49296aa - Browse repository at this point
Copy the full SHA 49296aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77ba874 - Browse repository at this point
Copy the full SHA 77ba874View commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 29bb08e - Browse repository at this point
Copy the full SHA 29bb08eView commit details -
Merge pull request #1042 from rommapp/romm-1018
[ROMM-1018] Fix scanning selected roms
Configuration menu - View commit details
-
Copy full SHA for 1e1d856 - Browse repository at this point
Copy the full SHA 1e1d856View commit details -
Merge pull request #1041 from rommapp/romm-1020
[ROMM-1020] Fix firmware pagination on mount
Configuration menu - View commit details
-
Copy full SHA for 05de165 - Browse repository at this point
Copy the full SHA 05de165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6941514 - Browse repository at this point
Copy the full SHA 6941514View commit details -
Configuration menu - View commit details
-
Copy full SHA for fce451a - Browse repository at this point
Copy the full SHA fce451aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48bdfb9 - Browse repository at this point
Copy the full SHA 48bdfb9View commit details -
Merge pull request #1045 from rommapp/hotfix-related-games
Hotfix and link from related games
Configuration menu - View commit details
-
Copy full SHA for 535cb5a - Browse repository at this point
Copy the full SHA 535cb5aView commit details
Commits on Jul 30, 2024
-
Fix incorrectly converted platform icons
Hotfix for the previously submitted additional icons. Corrects low res/white background issue.
Configuration menu - View commit details
-
Copy full SHA for 1e58417 - Browse repository at this point
Copy the full SHA 1e58417View commit details -
Merge pull request #1046 from Casuallynoted/master
Fix incorrectly converted platform icons
Configuration menu - View commit details
-
Copy full SHA for 072fc9e - Browse repository at this point
Copy the full SHA 072fc9eView commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 697723a - Browse repository at this point
Copy the full SHA 697723aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f7058d - Browse repository at this point
Copy the full SHA 9f7058dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cd4cf1 - Browse repository at this point
Copy the full SHA 8cd4cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c77ca88 - Browse repository at this point
Copy the full SHA c77ca88View commit details
Commits on Aug 3, 2024
-
Merge pull request #1044 from rommapp/romm-1012
[ROMM-1012] Fix multi-file download in gakllery view
Configuration menu - View commit details
-
Copy full SHA for ebd0c07 - Browse repository at this point
Copy the full SHA ebd0c07View commit details
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eba529b - Browse repository at this point
Copy the full SHA eba529bView commit details -
Merge pull request #1036 from rommapp/romm-1031
[ROMM-1031] Remove persistent overlay prevents back navigation
Configuration menu - View commit details
-
Copy full SHA for f437bac - Browse repository at this point
Copy the full SHA f437bacView commit details -
Update frontend/src/components/Details/Info/GameInfo.vue
Co-authored-by: Zurdi <34356590+zurdi15@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6d366aa - Browse repository at this point
Copy the full SHA 6d366aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d6b96b - Browse repository at this point
Copy the full SHA 6d6b96bView commit details -
Merge pull request #1040 from rommapp/romm-1019
[ROMM-1019] Clickable filter buttons on details view
Configuration menu - View commit details
-
Copy full SHA for ed96603 - Browse repository at this point
Copy the full SHA ed96603View commit details -
Merge pull request #1043 from rommapp/romm-1022
[ROMM-1022] Add button to show duplicates
Configuration menu - View commit details
-
Copy full SHA for b06b0f4 - Browse repository at this point
Copy the full SHA b06b0f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32823af - Browse repository at this point
Copy the full SHA 32823afView commit details -
Merge pull request #1054 from rommapp/romm-1052
Added link to home button
Configuration menu - View commit details
-
Copy full SHA for 7e52b50 - Browse repository at this point
Copy the full SHA 7e52b50View commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebe570d - Browse repository at this point
Copy the full SHA ebe570dView commit details -
Merge pull request #1055 from rommapp/type-fix-additional-content
Add workflow that runs typecheck on PRs
Configuration menu - View commit details
-
Copy full SHA for 9b4206a - Browse repository at this point
Copy the full SHA 9b4206aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9a68ad - Browse repository at this point
Copy the full SHA b9a68adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02cf0fd - Browse repository at this point
Copy the full SHA 02cf0fdView commit details -
fix: Backend URL redirection logic
Fix FastAPI and nginx configuration, to make the application correctly redirect URLs. This is specially useful when URLs ended with forward slash are redirected to their stripped version. Included changes: * Stop removing the `/api` prefix in nginx rewrite rules, so FastAPI knows what's the original URL path being requested. * Use `$http_host` in nginx, so FastAPI receives both the original host and port, to build the redirect URL (as `$host` does not include the port, if present). * Make all FastAPI included routers know their prefix, to correctly route incoming requests. This fix was found based on a report that redirects from URLs ended with forward slash were not working [1]. [1] #1051 (comment)
Configuration menu - View commit details
-
Copy full SHA for 45aeaf3 - Browse repository at this point
Copy the full SHA 45aeaf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 805a688 - Browse repository at this point
Copy the full SHA 805a688View commit details -
Configuration menu - View commit details
-
Copy full SHA for a53c091 - Browse repository at this point
Copy the full SHA a53c091View commit details -
Configuration menu - View commit details
-
Copy full SHA for d17cdd6 - Browse repository at this point
Copy the full SHA d17cdd6View commit details -
Merge pull request #1058 from rommapp/fix/fastapi-redirections
fix: Backend URL redirection logic
Configuration menu - View commit details
-
Copy full SHA for cbab9f6 - Browse repository at this point
Copy the full SHA cbab9f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ada7f5f - Browse repository at this point
Copy the full SHA ada7f5fView commit details
Commits on Aug 6, 2024
-
Merge pull request #1057 from rommapp/fix/csrf-token
Fix CSRF token issues
Configuration menu - View commit details
-
Copy full SHA for 76d6798 - Browse repository at this point
Copy the full SHA 76d6798View commit details
Commits on Aug 7, 2024
-
misc: Make backend handle URLs with trailing slash
According to multiple FastAPI discussions [1], FastAPI only includes a built-in mechanism to redirect requests including a trailing slash, to its variation without slash, using a `307` status code. This can be an issue when certain clients do not send the same headers on the redirected request. This change adds a custom FastAPI `APIRouter`, that registers both route path variations (with and without trailing slash), while only marking the path without slash for being included in the OpenAPI schema. [1] fastapi/fastapi#7298
Configuration menu - View commit details
-
Copy full SHA for 8abbae4 - Browse repository at this point
Copy the full SHA 8abbae4View commit details -
Merge pull request #1059 from rommapp/misc/backend-handle-trailing-slash
misc: Make backend handle URLs with trailing slash
Configuration menu - View commit details
-
Copy full SHA for 5e17efc - Browse repository at this point
Copy the full SHA 5e17efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbeac18 - Browse repository at this point
Copy the full SHA cbeac18View commit details -
Merge pull request #1060 from rommapp/drop-auth-user-pass
Drop ROMM_AUTH_USERNAME and ROMM_AUTH_PASSWORD env variables
Configuration menu - View commit details
-
Copy full SHA for 51ee99e - Browse repository at this point
Copy the full SHA 51ee99eView commit details