v3.5.0 #1140
Merged
v3.5.0 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add typing for nested objects in Tinfoil and Webrcade feed schemas. * Do not send Rom background and thumbnail, if not available. * Correctly build URLs using `starlette` utils. * Deprecate the `ROMM_HOST` setting, no longer needed. * Fix FastAPI custom router to prefer routes without trailing slash. * Fix Webrcade background URL pointing to gallery screenshot.
misc: Improve typing for feed schemas
[ROMM-1063] Add Amiga CD32 to emulatorjs game list
fix: fab overlay fixed
fix: Readable setup text on white theme
Currently, the `request.url_for` and `URLPath.make_absolute_url` methods always build URLs with "http" scheme, even when the original requested URL is using "https". The reason for this is that Gunicorn does not allow IPs other than 127.0.0.1 to set secure headers by default. As regular RomM installations don't know which frontend IPs will try to set security headers in advance, we can disable this validation, and fix URL building. A simple way to test this change is to access any of the `feed` endpoints, which generate URLs using the mentioned methods. Accessing the endpoint using "https" scheme must generate "https" URLs. Reference: * encode/starlette#538 (comment) * https://docs.gunicorn.org/en/stable/settings.html#forwarded-allow-ips
This matches the behavior of the Webrcade feed.
Bump axios to 1.7.4
[ROMM-1107] Add env variable to disable in-browser emulation
Default both fast forward and rewind to enabled
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
Allow user to unmatch rom
Test Results81 tests 81 ✅ 21s ⏱️ Results for commit 72fc6d8. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.