misc: Simplify backend environment configuration in Docker image #947

adamantike · 2024-06-22T21:19:59Z

This change moves the virtualenv creation in the Dockerfile to a separate stage, to simplify isolating the process and reduce the need for uninstalling build dependencies.

The approach is similar to the one explained in [1]. It relies on building a virtualenv folder, and copying it in the final stage. Changing the PATH environment variable makes the virtualenv usable by default, without affecting the default Python installation.

Also, added Dockerfile arguments for Alpine, nginx, and Python versions, as some of them are reused, and also simplifies testing new versions.

An extra side effect is that the image size for the final stage is reduced from 315MB to 262MB.

[1] https://scribe.rip/@albertazzir/blazing-fast-python-docker-builds-with-poetry-a78a66f5aed0

This change moves the virtualenv creation in the `Dockerfile` to a separate stage, to simplify isolating the process and reduce the need for uninstalling build dependencies. The approach is similar to the one explained in [1]. It relies on building a virtualenv folder, and copying it in the final stage. Changing the `PATH` environment variable makes the virtualenv usable by default, without affecting the default Python installation. Also, added Dockerfile arguments for Alpine, nginx, and Python versions, as some of them are reused, and also simplifies testing new versions. An extra side effect is that the image size for the final stage is reduced from 315MB to 262MB. [1] https://scribe.rip/@albertazzir/blazing-fast-python-docker-builds-with-poetry-a78a66f5aed0

gantoine

this is dope! will build it on my server once i'm back home to test.

gantoine · 2024-06-22T23:16:24Z

docker/Dockerfile

@@ -1,11 +1,33 @@
+ARG ALPINE_VERSION=3.19
+ARG NGINX_VERSION=1.27.0
+ARG PYTHON_VERSION=3.11


docker/Dockerfile

gantoine · 2024-06-23T14:02:25Z

docker/Dockerfile

+COPY --from=backend-build /src/.venv /src/.venv
+# Fix virtualenv link to python binary
+RUN ln -sf "$(which python)" /src/.venv/bin/python
+ENV PATH="/src/.venv/bin:${PATH}"


docker/init_scripts/init

gantoine requested changes Jun 23, 2024

View reviewed changes

gantoine approved these changes Jun 23, 2024

View reviewed changes

gantoine merged commit dca2a59 into rommapp:master Jun 23, 2024
2 checks passed

adamantike deleted the misc/simplify-dockerfile-backend branch June 23, 2024 14:23

zurdi15 mentioned this pull request Jul 19, 2024

v3.3.0 #989

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc: Simplify backend environment configuration in Docker image #947

misc: Simplify backend environment configuration in Docker image #947

adamantike commented Jun 22, 2024

gantoine left a comment

gantoine Jun 22, 2024

gantoine Jun 23, 2024

misc: Simplify backend environment configuration in Docker image #947

misc: Simplify backend environment configuration in Docker image #947

Conversation

adamantike commented Jun 22, 2024

gantoine left a comment

Choose a reason for hiding this comment

gantoine Jun 22, 2024

Choose a reason for hiding this comment

gantoine Jun 23, 2024

Choose a reason for hiding this comment