Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyobjcTools/Conversion.py file throws error when running as 3.7 #289

Closed
ronaldoussoren opened this issue Jan 29, 2020 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@ronaldoussoren
Copy link
Owner

Original report by vinolin asokan (Bitbucket: [vinolin asokan](https://bitbucket.org/vinolin asokan), ).


Running my test with py 3.7 version. it throws error at line 188 at the return statement because of the buffer function.

(To resolve just implement the version check and added buffer = memory view)

@ronaldoussoren
Copy link
Owner Author

Original comment by Ronald Oussoren (Bitbucket: ronaldoussoren, GitHub: ronaldoussoren).


Thanks for the report. I though I had found all Python 3 issues by now, but appearently not 😞.

@ronaldoussoren
Copy link
Owner Author

Original comment by Ronald Oussoren (Bitbucket: ronaldoussoren, GitHub: ronaldoussoren).


Fix test coverage for PyObjCTools.Conversion

Fixes #289, as well as fixing some other problems with that code

@ronaldoussoren
Copy link
Owner Author

Original comment by Ronald Oussoren (Bitbucket: ronaldoussoren, GitHub: ronaldoussoren).


The issue has been fixed in the repository, as well as some other problems with this part of the code.

I don’t know yet when I’ll push out a release with this fix, probably after the upcoming migration to GitHub.

@ronaldoussoren
Copy link
Owner Author

Original comment by vinolin asokan (Bitbucket: [vinolin asokan](https://bitbucket.org/vinolin asokan), ).


Thank you so much for the response and I am eagerly looking forward for the new build :slight_smile:

@ronaldoussoren ronaldoussoren added major bug Something isn't working labels Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant