Fix NETSDK1074.

NETSDK1074: The application host executable will not be customized because adding resources requires that the build be performed on Windows. See: dotnet/runtime#3828
ronaldvanmanen · Sep 13, 2023 · 0eec941 · 0eec941
1 parent 56edfac
commit 0eec941
Show file tree

Hide file tree

Showing 9 changed files with 57 additions and 17 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -61,7 +61,7 @@ jobs:
     - run: ./scripts/cibuild.sh --configuration ${{ matrix.configuration }} --architecture ${{ matrix.architecture }}
       shell: bash
       env: 
-        OVERRIDE_RUNTIME_IDENTIFIER: win-${{ matrix.architecture }}
+        OVERRIDE_RUNTIME_IDENTIFIER: linux-${{ matrix.architecture }}
     - uses: actions/upload-artifact@v3
       with:
         name: ${{ matrix.os }}_${{ matrix.configuration }}_${{ matrix.architecture }}

diff --git a/samples/AverageFrameRate/AverageFrameRate.csproj b/samples/AverageFrameRate/AverageFrameRate.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/BitmapViewer/BitmapViewer.csproj b/samples/BitmapViewer/BitmapViewer.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/ParticleSystem/ParticleSystem.csproj b/samples/ParticleSystem/ParticleSystem.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/PlasmaFractal/PlasmaFractal.csproj b/samples/PlasmaFractal/PlasmaFractal.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/RayTracer/RayTracer.csproj b/samples/RayTracer/RayTracer.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/SwirlStars/SwirlStars.csproj b/samples/SwirlStars/SwirlStars.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/TunnelEffect/TunnelEffect.csproj b/samples/TunnelEffect/TunnelEffect.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/WavePlayer/WavePlayer.csproj b/samples/WavePlayer/WavePlayer.csproj
@@ -3,8 +3,13 @@
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
-    <ApplicationIcon />
-    <StartupObject />
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>