Fix NETSDK1074.

NETSDK1074: The application host executable will not be customized because adding resources requires that the build be performed on Windows. See: dotnet/runtime#3828
ronaldvanmanen · Sep 11, 2023 · 2a099a0 · 2a099a0
1 parent 56edfac
commit 2a099a0
Show file tree

Hide file tree

Showing 9 changed files with 59 additions and 1 deletion.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -13,7 +13,9 @@
   <!-- Settings that append the existing setting value -->
   <PropertyGroup>
     <DefineConstants>$(DefineConstants);$(OS)</DefineConstants>
-    <NoWarn>$(NoWarn);NU5105</NoWarn>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <NoWarn>$(NoWarn);NU5105;NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
   </PropertyGroup>
 
   <!-- Settings that allow testing and packing to work by default -->

diff --git a/samples/AverageFrameRate/AverageFrameRate.csproj b/samples/AverageFrameRate/AverageFrameRate.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/BitmapViewer/BitmapViewer.csproj b/samples/BitmapViewer/BitmapViewer.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="Sample.bmp">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/ParticleSystem/ParticleSystem.csproj b/samples/ParticleSystem/ParticleSystem.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/PlasmaFractal/PlasmaFractal.csproj b/samples/PlasmaFractal/PlasmaFractal.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/RayTracer/RayTracer.csproj b/samples/RayTracer/RayTracer.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/SwirlStars/SwirlStars.csproj b/samples/SwirlStars/SwirlStars.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/TunnelEffect/TunnelEffect.csproj b/samples/TunnelEffect/TunnelEffect.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

diff --git a/samples/WavePlayer/WavePlayer.csproj b/samples/WavePlayer/WavePlayer.csproj
@@ -7,6 +7,13 @@
     <StartupObject />
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- TODO: https://github.com/dotnet/runtime/issues/3828 -->
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <NoWarn>$(NoWarn);NETSDK1074</NoWarn>
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NETSDK1074</WarningsNotAsErrors>
+  </PropertyGroup>
+
   <ItemGroup>
     <Content Include="lazy.ttf">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>