feat: upgradeable beacon proxy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Comment on lines
+27
to
+28
| address poolImplementation = address(new KatanaV3Pool()); | ||
| beacon = address(new UpgradeableBeacon(poolImplementation)); |
There was a problem hiding this comment.
Any reason to deploy UpgradeableBeacon and pool implementation within factory constructor?
| function initializeImmutables(address factory_, address token0_, address token1_, uint24 fee_, int24 tickSpacing_) | ||
| public | ||
| { | ||
| require(!_immutablesInitialized); |
| constructor() BeaconProxy(address(0), "") { } | ||
|
|
||
| /// @dev This function will be called with zero arguments but modified to include the pool's immutable parameters. | ||
| function _setBeacon(address beacon, bytes memory data) internal virtual override { |
There was a problem hiding this comment.
This param should be ignored since we always set the beacon using the address stored in factory.
Suggested change
| function _setBeacon(address beacon, bytes memory data) internal virtual override { | |
| function _setBeacon(address, bytes memory data) internal virtual override { |
| /// @dev This function will be called with zero arguments but modified to include the pool's immutable parameters. | ||
| function _setBeacon(address beacon, bytes memory data) internal virtual override { | ||
| (address factory, address token0, address token1, uint24 fee, int24 tickSpacing) = | ||
| IKatanaV3PoolDeployer(msg.sender).parameters(); |
There was a problem hiding this comment.
This method is called whenever the UpgradeableBeacon is updated. However by this time, the parameters stored in PoolDeployer has already been deleted and always return 0 for all.
TuDo1403
reviewed
Aug 19, 2024
thaixuandang
changed the base branch from
feature/rename-and-format
to
release/v1.0.0
…upgradeable-beacon-proxy chore(`upgradeable-beacon-proxy`): merge from `release/v1.0.0`
|
Already refactored in PR#13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist