Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bpm fuzzy halfdouble #68

Conversation

daschuer
Copy link

@daschuer daschuer commented Apr 7, 2024

I have notices that a even value only matches the exact .0 value.
This PR fixes this and also extend the uneven range a bit.

bpm Bpm/2 low high (exlusive) in Library
126 63 62,95 64 63.0 .. 63.9
127 63,5 62,95 64,5 63.0 .. 64.4
128 64 63,95 65 64.0 .. 64.9
129 64,5 63,95 65,5 64.0 .. 63.4
130 65 64,95 66 65.0 .. 65.9

@ronso0
Copy link
Owner

ronso0 commented Apr 7, 2024

Thanks for polishing!
Please fix the comment indentation and squash.

@coveralls
Copy link

coveralls commented Apr 7, 2024

Pull Request Test Coverage Report for Build 8590780872

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 31.188%

Totals Coverage Status
Change from base Build 8583895209: 0.004%
Covered Lines: 31082
Relevant Lines: 99661

💛 - Coveralls

@daschuer daschuer force-pushed the search-bpm-fuzzy-halfdouble branch from fadadee to fa35e36 Compare April 7, 2024 18:26
@daschuer
Copy link
Author

daschuer commented Apr 7, 2024

Oh sorry, fixed.

@ronso0
Copy link
Owner

ronso0 commented Apr 7, 2024

Thanks. I removed the debug output and picked the commits

@ronso0 ronso0 closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants