Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoMethodError - undefined method `start_with?' for #<Tempfile:0x007f99a47bf1e8>: #84

Closed
swiftslipper opened this issue Nov 13, 2013 · 4 comments
Closed

NoMethodError - undefined method `start_with?' for #<Tempfile:0x007f99a47bf1e8>: #84

swiftslipper opened this issue Nov 13, 2013 · 4 comments

Comments

@swiftslipper
Copy link

Roo::Spreadsheet.open does not accept Tempfile, because it specifically checks for File, which is not ideal, since there are many classes that can implement File interface.

This patch introduces duck typing.
swiftslipper pushed a commit to swiftslipper/roo that referenced this issue Nov 13, 2013
fixes roo-rb#84
39be352
@Empact
Copy link
Contributor

Empact commented Dec 5, 2013

Thanks dmitry - could you create a pull request, and check for the method being depended on? i.e. respond_to?(:path)

@Empact Empact closed this as completed in 298237c Dec 23, 2013
@szabcsee
Copy link

Hi Empact, Sorry but I don't see this being fixed. I still get the error as roo can't handle the :tempfile I just uploaded. Or am I doing something wrong?

@nobuf
Copy link
Contributor

nobuf commented Mar 6, 2014

I've faced the same error on v1.13.2.

@Empact
Copy link
Contributor

Empact commented Mar 6, 2014

Feel free to make a pull request to fix! I don't have time to investigate and fix these bugs at the moment.

nobuf added a commit to nobuf/roo that referenced this issue Mar 6, 2014
@nobuf
fix roo-rb#84 check if the filename is String. filename could be Temp…
f1ed7ce 
…file, for instance.
@nobuf nobuf mentioned this issue Mar 6, 2014
Merged
nobuf added a commit to nobuf/roo that referenced this issue Aug 4, 2014
@nobuf
change some code based on @simonoff's suggestion, add a test roo-rb#84
1268bee
simonoff added a commit that referenced this issue Aug 4, 2014
@simonoff
Merge pull request #118 from nobuf/master
daeb688 
fix #84 check if the filename is String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Empact @nobuf @szabcsee @swiftslipper