Fix xlsx datetimes #104
Merged
Fix xlsx datetimes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 3, 2014 09:50
The failures were specific to xlsx format spreadsheets. When setting the date time to a string format, we need to round to the nearest second.
When supplying a date time string with seconds (11/5/2013 11:45:00), the resulting DateTime object would not round the fractional seconds resulting in a time string of 11/5/2013 11:44:59. Time is now properly rounded before returning the DateTime object.
|
+1 Fixes my problem Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #103.
The failures were specific to xlsx format spreadsheets. When setting the date time to a string format, we need to round to the nearest second.