Prevent inspect from being called recursively

[kshahkshah]

This is related to the problems with 2.0.0 and the Spreadsheet gem.

It appears this simple fix will prevent absurdly long load times on calls like:

spreadsheet = Roo::Excel.new("foo.xls")

as opposed to:

Roo::Excel.new("foo.xls").first_line

which has always run quite quickly.

The difference is the first version, when called in a program like IRB implicitly calls inspect, which (I think?) recursively calls inspect on all the nested instance variables, again, I think. Even files of a relatively small size (165kb xls) were taking hours to load before I made this change, now it takes a brief second.

[dborin]

Please reopen this. This is NOT fixed. Doing

s = Roo::Excel.new('./foo.xls')

and

s = Roo::Excel.new('./foo.xls').inspect

Result in the same insane output of reading something (unsure what since my foo.xls is two columns with three rows) that takes upwards of 5 minutes to load.

[kshahkshah]

I'll take a look in the morning. What Ruby are you running?
On Sep 30, 2014 12:06 AM, "David Borin" notifications@github.com wrote:

Please reopen this. This is NOT fixed. Doing

s = Roo::Excel.new('./foo.xls')

and

s = Roo::Excel.new('./foo.xls').inspect

Result in the same insane output of reading something (unsure what since
my foo.xls is two columns with three rows) that takes upwards of 5 minutes
to load.

—
Reply to this email directly or view it on GitHub
#115 (comment).

[dborin]

2.0.0-p481, but I saw this in 2.1.1 as well :( Creek is able to quickly
load up this file when I convert it to xlsx.

On Mon, Sep 29, 2014 at 9:28 PM, Kunal Shah notifications@github.com
wrote:

I'll take a look in the morning. What Ruby are you running?
On Sep 30, 2014 12:06 AM, "David Borin" notifications@github.com wrote:

Please reopen this. This is NOT fixed. Doing

s = Roo::Excel.new('./foo.xls')

and

s = Roo::Excel.new('./foo.xls').inspect

Result in the same insane output of reading something (unsure what since
my foo.xls is two columns with three rows) that takes upwards of 5
minutes
to load.

—
Reply to this email directly or view it on GitHub
#115 (comment).

—
Reply to this email directly or view it on GitHub
#115 (comment).

[dborin]

And thanks for looking at this so quickly

[alainmeier]

+1 I am getting the same issue on 2.1.3p242