Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value from formula? method should be consistent. #191

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Return value from formula? method should be consistent. #191

merged 1 commit into from
Mar 31, 2015

Conversation

stevendaniels
Copy link
Contributor

Roo::Excelx#formula? now returns true/false, so Roo::OpenOffice#formula? should also return true/false.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.52% when pulling fe29f9f on stevendaniels:make-formula-methods-consistent into 72b1532 on roo-rb:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.52% when pulling fe29f9f on stevendaniels:make-formula-methods-consistent into 72b1532 on roo-rb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.52% when pulling fe29f9f on stevendaniels:make-formula-methods-consistent into 72b1532 on roo-rb:master.

simonoff added a commit that referenced this pull request Mar 31, 2015
@simonoff
Merge pull request #191 from stevendaniels/make-formula-methods-consi…
7f6b8e3 
…stent

Return value from formula? method should be consistent.
@simonoff simonoff merged commit 7f6b8e3 into roo-rb:master Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendaniels @coveralls @simonoff