Cleanup Excelx #215
Merged
Cleanup Excelx #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Autoload Excelx::Cell and Excelx::Sheet + Added excelx/cell.rb + Added exelx/sheet.rb
+ Used Regexp capture match groups instead of multiple `split` methods + added private `create_date` method + renamed private methods
1 similar comment
| :datetime | ||
| module Roo | ||
| class Excelx < Roo::Base | ||
| autoload :Workbook, 'roo/excelx/workbook' |
There was a problem hiding this comment.
I think we can require this modules except of autoload. No need to make autoload there.
|
@simonoff Thanks. I'll work on those changes. |
+ require Excelx's submodules instead of autoloading. + Use guard class in Excelx::Comments#extract_comments and Excelx::Relationships.extract_relationships + Updated conditionals in Excelx::Cell.
stevendaniels
force-pushed
the
cleanup_excelx
branch
from
9c93e7e to
023bc4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.