Allow Roo::Excelx to open streams, correctly this time #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excel files exported from Google, for example, aren't supported. Using Zip::CentralDirectory instead seems to do the trick.
simonoff
added a commit
that referenced
this pull request
Jun 3, 2015
Allow Roo::Excelx to open streams, correctly this time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the approach I used in #209, using
Zip::InputStream,doesn't correctly handle certain files, specifically ones created by Numbers
and Google Spreadsheets. Using
Zip::CentralDirectoryinstead handles thesefiles correctly.