Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address typing hints for xarray 2023.08 compatibility, Update ReadTheDocs #295

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Aug 21, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:

Fixes an issue with existing type hinting raised by changes in the API of xarray (2023.08).

Also updates the ReadTheDocs configuration to use Mambaforge by default.

  • Does this PR introduce a breaking change?:

No. Only type hinting is affected (it's more accurate now).

  • Other information:

pydata/xarray#7368

@Zeitsperre Zeitsperre added bug Something isn't working deprecation Something needs to change labels Aug 21, 2023
@Zeitsperre Zeitsperre self-assigned this Aug 21, 2023
@coveralls
Copy link

coveralls commented Aug 21, 2023

Pull Request Test Coverage Report for Build 5929676609

  • 23 of 24 (95.83%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 78.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clisops/core/subset.py 21 22 95.45%
Totals Coverage Status
Change from base Build 5718256149: 0.03%
Covered Lines: 1109
Relevant Lines: 1413

💛 - Coveralls

@Zeitsperre Zeitsperre requested a review from huard August 21, 2023 18:00
@@ -2,7 +2,7 @@ name: clisops
channels:
- conda-forge
dependencies:
- python >=3.8
- python >=3.8,<3.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why < 3.12 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReadTheDocs will try to build the documentation with the highest available version. CLISOPS only supports Python >=3.8,<3.12 at the moment.

@Zeitsperre Zeitsperre changed the title Address typing hints for xarray 2023.08 compatibility Address typing hints for xarray 2023.08 compatibility, Update ReadTheDocs Aug 21, 2023
@Zeitsperre Zeitsperre merged commit 4eb3e1e into master Aug 21, 2023
8 checks passed
@Zeitsperre Zeitsperre deleted the adapt-xarray branch August 21, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation Something needs to change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants