Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mons: restore-quorum should proceed with probing #324

Merged
merged 2 commits into from
Sep 11, 2024
Merged

mons: restore-quorum should proceed with probing #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
700df51
mons: restore-quorum should procced with probing
subhamkrai Sep 11, 2024
5d1c2b8
ci: update upload-artifact version
subhamkrai Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/collect-logs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ runs:
tests/collect-logs.sh

- name: Upload canary test result
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.name }}
path: test
2 changes: 1 addition & 1 deletion pkg/mons/restore_quorum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ func validateMonIsUp(ctx context.Context, clientsets *k8sutil.Clientsets, cluste

logging.Info("mon %q state is %q", monID, monStatusOut.State)

if monStatusOut.State == "leader" || monStatusOut.State == "peon" {
if monStatusOut.State == "leader" || monStatusOut.State == "peon" || monStatusOut.State == "probing" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhamkrai try to change this error message in future PR

return fmt.Errorf("mon %q in %q state but must be in leader/peon/probing state", monID, monStatusOut.State)

return nil
}

Expand Down
Loading