Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update min K8s support to 1.21 and add 1.26 support #11436

Merged
merged 2 commits into from
Feb 15, 2023
Merged

ci: Update min K8s support to 1.21 and add 1.26 support #11436

merged 2 commits into from
Feb 15, 2023

Conversation

subhamkrai
Copy link
Contributor

this commit bump minmum k8s version to 1.21.14 and max k8s version to latest 1.26.0. Keeping support for most recent 6 versions.

Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai subhamkrai added the ci label Dec 14, 2022
@subhamkrai
Copy link
Contributor Author

I moved the min k8s version from 1.19.x to 1.21.x and the max k8s from 1.25.x to 1.26.0 to support the most recent 6 versions, somehow earlier we had support from 1.19.x to 1.25 which technically supports 7 versions 😀

@subhamkrai subhamkrai requested a review from travisn December 14, 2022 03:27
@subhamkrai
Copy link
Contributor Author

we are waiting for the support of the latest k8s version from the action provider manusa/actions-setup-minikube#76

travisn
travisn requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quickstart.md has the min version that also needs to be updated to v1.21. Looks like it was missed the last time we bumped the version.

.github/workflows/integration-tests-on-release.yaml Outdated Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
@travisn travisn changed the title ci: bump min and max k8s support ci: Update min K8s support to 1.21 and add 1.26 support Dec 14, 2022
@travisn
Copy link
Member

travisn commented Dec 14, 2022

The quickstart.md has the min version that also needs to be updated to v1.21. Looks like it was missed the last time we bumped the version.

Also in prerequisites.md

@subhamkrai
Copy link
Contributor Author

@Mergifyio rebase

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Labeled by the stale bot label Jan 14, 2023
@subhamkrai subhamkrai removed the stale Labeled by the stale bot label Jan 16, 2023
@travisn travisn force-pushed the bump-ci-k8s-version branch 5 times, most recently from 08616c6 to b154c19 Compare February 9, 2023 00:03
@subhamkrai subhamkrai force-pushed the bump-ci-k8s-version branch 11 times, most recently from 6d0e8bd to 1d01738 Compare February 9, 2023 05:12
@subhamkrai subhamkrai force-pushed the bump-ci-k8s-version branch 9 times, most recently from 3ca3298 to fc7c162 Compare February 10, 2023 03:47
@subhamkrai
Copy link
Contributor Author

The quickstart.md has the min version that also needs to be updated to v1.21. Looks like it was missed the last time we bumped the version.

Also in prerequisites.md

done

@subhamkrai
ci: bump min and max k8s support
d84d139 
this commit bump minmum k8s version to 1.21.14 and
max k8s version to latest 1.26.0. Keeping support for
most recent 6 versions.

Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai subhamkrai requested a review from travisn February 10, 2023 08:56
travisn
travisn requested changes Feb 10, 2023
View reviewed changes
tests/scripts/github-action-helper.sh Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
.github/workflows/canary-test-config/action.yaml Outdated Show resolved Hide resolved
.github/workflows/canary-test-config/action.yaml Outdated Show resolved Hide resolved
@subhamkrai subhamkrai force-pushed the bump-ci-k8s-version branch 2 times, most recently from 5a36852 to 61511e0 Compare February 13, 2023 13:22
travisn
travisn requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see the green CI with these version updates!

tests/scripts/github-action-helper.sh Outdated Show resolved Hide resolved
tests/scripts/github-action-helper.sh Outdated Show resolved Hide resolved
@travisn travisn mentioned this pull request Feb 13, 2023
Closed
7 tasks
@subhamkrai
ci: bump min and max k8s support
1effb11 
this commit bump minmum k8s version to 1.21.14 and
max k8s version to latest 1.26.0. Keeping support for
most recent 6 versions.

Signed-off-by: subhamkrai <srai@redhat.com>
@travisn travisn merged commit 11e80b7 into rook:master Feb 15, 2023
@subhamkrai subhamkrai deleted the bump-ci-k8s-version branch February 15, 2023 05:41
@travisn travisn mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhamkrai @travisn