build: remove iproute build dependency on centos repo #14299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
approved these changes
Jun 3, 2024
| # have other package build errors. In order to make sure Rook CI catches the eventual removal and | ||
| # also limit Rook CI breakage due to centos breakage, simply check that 'ip' is present. | ||
| # Eventually: dnf install -y --repo baseos --setopt=install_weak_deps=False iproute && dnf clean all | ||
| RUN which ip |
There was a problem hiding this comment.
This fails the build if not found?
There was a problem hiding this comment.
Correct. In the eventual future, when ip is removed from the image, CI will start failing, and we will need to add the dnf install (or equivalent) line back to the build. But until then, this should succeed without adding a hard dependency on CentOS repos.
Multus requires that the 'ip' tool be installed in the Rook image. Today, it is present in the upstream Ceph base image that is used, but that is expected to change in the future. The Ceph project intends to switch to CentOS 9 minimal images, and the 'ip' tool will likely be removed from the base image at that point. However, Rook CI has occasionally had issues with the current 'dnf install' command when CentOS repos go down, or when there is otherwise some problem. Because the package is already installed today, there is no need to hamstring Rook builds when CentOS is having problems. But we do want to make sure that Rook builds don't silently succeed in the eventual future when 'ip' tool is removed from the Ceph image. For now, replace the 'dnf install' with a check to verify that 'ip' tool is installed, and add a shorter form of this note as a comment above it to help Rook maintainers know how to resolve future 'ip' tool removal. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
remove-centos-baseos-repo-dependency
branch
from
87bc8d3 to
c4e99c1
Compare
|
DCO check is stuck in "Waiting for status to be reported" state as noted here: https://github.com/orgs/community/discussions/26698#discussioncomment-9654155 Will manually merge when other CI passes successfully. |
6 tasks
BlaineEXE
added a commit
that referenced
this pull request
Jun 3, 2024
build: remove iproute build dependency on centos repo (backport #14299)
6 tasks
6 tasks
BlaineEXE
added a commit
that referenced
this pull request
Jun 26, 2024
build: remove iproute build dependency on centos repo (backport #14299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multus requires that the 'ip' tool be installed in the Rook image. Today, it is present in the upstream Ceph base image that is used, but that is expected to change in the future. The Ceph project intends to switch to CentOS 9 minimal images, and the 'ip' tool will likely be removed from the base image at that point.
However, Rook CI has occasionally had issues with the current 'dnf install' command when CentOS repos go down, or when there is otherwise some problem. Because the package is already installed today, there is no need to hamstring Rook builds when CentOS is having problems. But we do want to make sure that Rook builds don't silently succeed in the eventual future when 'ip' tool is removed from the Ceph image.
For now, replace the 'dnf install' with a check to verify that 'ip' tool is installed, and add a shorter form of this note as a comment above it to help Rook maintainers know how to resolve future 'ip' tool removal.
I am proposing this in lieu of #14296, but thank you @sp98 for finding the root cause !
Checklist: