Replace fwd decl of json with wrapper type #11196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nlohmann/json#3590, the
basic_json
class and thejson
using
-declaration are located in a "versioned, ABI-tagged inline namespace". This makes it impossible to forward declare the type inREveElement.hxx
.Instead introduce a new struct
REveJsonWrapper
that just wraps ajson
object (after including the fullnlohmann/json.hpp
). As thestruct
is under our control, we can easily forward declare the type and use it for method arguments.Fixes #11130