Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cling] Work around constructor priority bug [v6.32] #16462

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Sep 18, 2024

LLVM had a bug where constructors with the same priority would not be stably sorted. This has been fixed upstream by
llvm/llvm-project#95532, but to avoid relying on a backport this commit works around the issue: The idea is that we lower the default priority of concerned constructors to make them sort correctly.

(cherry picked from commit 7db43f7, backport of #16420)

(cherry picked from commit 67ff470)
LLVM had a bug where constructors with the same priority would not be
stably sorted. This has been fixed upstream by
llvm/llvm-project#95532, but to avoid relying
on a backport this commit works around the issue: The idea is that we
lower the default priority of concerned constructors to make them sort
correctly.

(cherry picked from commit 7db43f7)
Copy link

github-actions bot commented Sep 18, 2024

Test Results

    11 files      11 suites   2d 15h 30m 41s ⏱️
 2 638 tests  2 635 ✅ 0 💤 3 ❌
27 232 runs  27 229 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 87fccf9.

♻️ This comment has been updated with latest results.

@hahnjo hahnjo merged commit b22db09 into root-project:v6-32-00-patches Sep 18, 2024
12 of 15 checks passed
@hahnjo hahnjo deleted the cling-constructors-v632 branch September 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant