[cxxmodules] Don't declare strings from rootmap for modules #3043

vgvassilev · 2018-11-25T20:51:00Z

We don't need any input_line declration from rootmap for startup time. However it may cause a failure on tests when they have custom dictionaries.

Should give 5MB improvements for modules.

Patch by Yuka Takahashi and me!

phsft-bot · 2018-11-25T20:51:12Z

Starting build on ROOT-centos7/python3, ROOT-fedora27/noimt, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-25T21:48:09Z

Build failed on ROOT-centos7/python3.
See console output.

Failing tests:

And 18 more

phsft-bot · 2018-11-25T22:22:13Z

Build failed on mac1014/cxx17.
See console output.

Failing tests:

And 15 more

phsft-bot · 2018-11-25T23:04:20Z

Build failed on windows10/default.
See console output.

phsft-bot · 2018-11-25T23:45:31Z

Build failed on ROOT-fedora27/noimt.
See console output.

Failing tests:

And 14 more

phsft-bot · 2018-11-25T23:52:21Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

And 143 more

vgvassilev · 2019-02-15T15:49:30Z

@phsft-bot build!

phsft-bot · 2019-02-15T15:49:41Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

phsft-bot · 2019-02-15T16:09:04Z

Build failed on ROOT-fedora27/noimt.
See console output.

Failing tests:

And 8 more

phsft-bot · 2019-02-15T16:13:48Z

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Failing tests:

And 7 more

phsft-bot · 2019-02-15T16:14:45Z

Build failed on ROOT-fedora29/python3.
See console output.

Failing tests:

And 6 more

phsft-bot · 2019-02-15T16:16:54Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

And 87 more

phsft-bot · 2019-02-15T16:17:41Z

Build failed on mac1014/cxx17.
See console output.

Failing tests:

And 7 more

phsft-bot · 2019-02-15T16:35:09Z

Build failed on windows10/default.
See console output.

phsft-bot · 2019-02-17T19:20:25Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

phsft-bot · 2019-02-17T21:09:44Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

phsft-bot · 2019-02-17T21:37:30Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

And 43 more

phsft-bot · 2019-03-26T21:43:21Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

phsft-bot · 2019-03-26T22:32:45Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

Error in <TInterpreter::TCling::AutoLoad>: failure loading library THistPainter.h for THistPainter
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TProfile.h for EErrorType
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t
Error in <TInterpreter::TCling::AutoLoad>: failure loading library TString.h for TString::Rep_t

And 399 more

phsft-bot · 2019-03-27T20:07:23Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

phsft-bot · 2019-03-27T20:13:31Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for shared_ptr<TObjLink>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_ptr<TObjLink>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_ptr<TObjLink>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for shared_ptr<TObjLink>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>
Error in <TInterpreter::TCling::AutoLoad>: failure loading library stl for __shared_count<__gnu_cxx::_Lock_policy::_S_atomic>

And 59 more

vgvassilev · 2019-05-05T11:41:21Z

The failures seem unrelated.

Axel-Naumann · 2019-05-05T18:45:38Z

@vgvassilev how so?

Axel-Naumann · 2019-05-06T11:24:06Z

@phsft-bot build just on mac1014/cxx17

phsft-bot · 2019-05-06T11:24:15Z

Starting build on mac1014/cxx17
How to customize builds

Axel-Naumann · 2019-05-06T12:41:11Z

Yup, @vgvassilev - build failures were unrelated! :-) And fixed!

amadio · 2019-05-06T13:45:37Z

What about Travis CI failure?

vgvassilev · 2019-05-06T20:03:56Z

@amadio, it also seems unrelated.

phsft-bot · 2019-05-07T21:16:22Z

Starting build on mac1014/cxx17
How to customize builds

phsft-bot · 2019-05-29T15:50:25Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

It gives more correct information whether we need a rootmap file.

This feature is used by clang to append the correct -l flags if a module is used. For example if we deserialize a from module A which has a link directive libA.so, clang will append -lA.so. ROOT and cling has dynamic linker. We should disable the default clang feature because it clashes with our implementation.

This patch allows given a name to deduce the library it is defined in. It uses the information provided in by the link directive in the module definition. This is useful to implement the TCling::AutoLoad interface for modules.

The usecase allows users to specify the headers only as #includes in the LinkDef file. This causes many subtleties such as incomplete modulemaps and inaccurate cmake dependencies.

The implementation of class->library mapping makes a call to the LookupHelper::findScope. This makes the recursive invocations to LookupHelper::findScope -> ... -> LookupHelper::findScope happen more often.

phsft-bot · 2019-05-30T21:02:50Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

vgvassilev · 2019-05-30T21:03:19Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-05-30T21:03:25Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-05-30T21:03:49Z

Build failed on mac1014/cxx17.
See console output.

Errors:

CMake Error at interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:120 (file):
CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:850 (message):

vgvassilev · 2019-05-30T21:06:17Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-05-30T21:06:24Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

vgvassilev requested a review from pcanal as a code owner November 25, 2018 20:51

vgvassilev mentioned this pull request Nov 25, 2018

[cxxmodules] Don't declare strings from rootmap for modules #2892

Closed

amadio assigned vgvassilev Nov 27, 2018

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 3680ca3 to 47fbb8b Compare February 17, 2019 19:20

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 47fbb8b to d3c7830 Compare February 17, 2019 21:09

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from d3c7830 to 5f2e54b Compare March 26, 2019 21:43

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 5f2e54b to 6ead6cb Compare March 27, 2019 20:07

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 6ead6cb to 62c773e Compare March 27, 2019 20:56

vgvassilev requested a review from amadio as a code owner March 27, 2019 20:56

vgvassilev requested a review from pcanal May 5, 2019 11:41

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from f84acab to 5d90a90 Compare May 7, 2019 21:16

vgvassilev mentioned this pull request May 10, 2019

Cxxmodules simplify lib registration #3798

Merged

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 5d90a90 to 16b698a Compare May 29, 2019 15:50

vgvassilev added 8 commits May 30, 2019 23:49

[cxxmodules] Use the newly created interface.

0ef360a

It gives more correct information whether we need a rootmap file.

Add early exit, fix indentation.

240a3d9

[cxxmodules] As per ROOT-7765 we might not have an owning module.

680d8ba

The usecase allows users to specify the headers only as #includes in the LinkDef file. This causes many subtleties such as incomplete modulemaps and inaccurate cmake dependencies.

[cling] Support recursive lookup helper calls.

7d7cc68

The implementation of class->library mapping makes a call to the LookupHelper::findScope. This makes the recursive invocations to LookupHelper::findScope -> ... -> LookupHelper::findScope happen more often.

[cxxmodules] Do not instantiate template when searching for a library.

83f4a59

[cxxmodules] Exit early when we know we cannot parse the request.

73c3f5f

vgvassilev force-pushed the yamaguchi1024-uniqstring branch from 16b698a to 73c3f5f Compare May 30, 2019 21:02

vgvassilev merged commit ee767d9 into root-project:master Jun 2, 2019

vgvassilev deleted the yamaguchi1024-uniqstring branch June 2, 2019 19:37

[cxxmodules] Don't declare strings from rootmap for modules #3043

[cxxmodules] Don't declare strings from rootmap for modules #3043

Conversation

vgvassilev commented Nov 25, 2018

phsft-bot commented Nov 25, 2018

phsft-bot commented Nov 25, 2018

Failing tests:

phsft-bot commented Nov 25, 2018

Failing tests:

phsft-bot commented Nov 25, 2018

phsft-bot commented Nov 25, 2018

Failing tests:

phsft-bot commented Nov 25, 2018

Failing tests:

vgvassilev commented Feb 15, 2019

phsft-bot commented Feb 15, 2019

phsft-bot commented Feb 15, 2019

Failing tests:

phsft-bot commented Feb 15, 2019

Failing tests:

phsft-bot commented Feb 15, 2019

Failing tests:

phsft-bot commented Feb 15, 2019

Failing tests:

phsft-bot commented Feb 15, 2019

Failing tests:

phsft-bot commented Feb 15, 2019

phsft-bot commented Feb 17, 2019

phsft-bot commented Feb 17, 2019

phsft-bot commented Feb 17, 2019

Failing tests:

phsft-bot commented Mar 26, 2019

phsft-bot commented Mar 26, 2019

Errors:

phsft-bot commented Mar 27, 2019

phsft-bot commented Mar 27, 2019

Errors:

vgvassilev commented May 5, 2019

Axel-Naumann commented May 5, 2019

Axel-Naumann commented May 6, 2019

phsft-bot commented May 6, 2019

Axel-Naumann commented May 6, 2019

amadio commented May 6, 2019

vgvassilev commented May 6, 2019

phsft-bot commented May 7, 2019

phsft-bot commented May 29, 2019

phsft-bot commented May 30, 2019

vgvassilev commented May 30, 2019

phsft-bot commented May 30, 2019

phsft-bot commented May 30, 2019

Errors:

vgvassilev commented May 30, 2019

phsft-bot commented May 30, 2019