Use forward decls for nlohmann/json types. #9278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cdfa69. We need to hide json includes: modules cannot cope with them, and it introduces a runtime requirement to find json.
This reverts commit 89c5d0c. This file does not exist on all platforms for external nlohmann. Will have to use "proper" fwd decls instead.
This reverts commit 1c38aa0. We cannot rely on json_fwd (does not exist for all nlohman packages). Will have to use proper fwd decls instead.
|
Starting build on |
|
Build failed on mac1015/python3. Failing tests: |
|
FYI, https://github.com/nlohmann/json/blame/develop/include/nlohmann/json_fwd.hpp#L27 shows how rarely this changes and demonstrates that (possibly version protected / restricted) fwd decls are viable. |
|
Test failure is unrelated (according to @eguiraud ). |
bellenot
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around issues with modules (alternative solution to #9267)