Reference gotcha with deployment featuring changes to .gitignore #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had a bad deploy and this comment is to remind us and others about the complexity of WordPress plugins in roots and interactions with .gitignore. If the plugin is composer managed, it's best to specify that in .gitignore because basically composer in roots wants to install that in web/app/plugins, which is source controlled. We don't want to see that plugin in our local working copies. But then we decided to move the advanced custom fields plugin from composer, where because of recent events it was not working like before, into directly managed source. And what we found recently was the first trellis deploy didn't come with the advanced custom fields source. We don't know why; maybe it's a trellis bug. Even if so, I don't think it would need to be fixed. Just tell people to deploy twice, problem solved. It repeatably failed for us the first time and worked for us the second deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a bad deploy and this comment is to remind us and others about the complexity of WordPress plugins in roots and interactions with .gitignore. If the plugin is composer managed, it's best to specify that in .gitignore because basically composer in roots wants to install that in web/app/plugins, which is source controlled. We don't want to see that plugin in our local working copies. But then we decided to move the advanced custom fields plugin from composer, where because of recent events it was not working like before, into directly managed source. And what we found recently was the first trellis deploy didn't come with the advanced custom fields source. We don't know why; maybe it's a trellis bug. Even if so, I don't think it would need to be fixed. Just tell people to deploy twice, problem solved. It repeatably failed for us the first time and worked for us the second deploy.