-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob pattern in lint:styles is not expanded in all shells #1950
Comments
retlehs
added a commit
that referenced
this issue
Aug 17, 2017
Issue #1950: Fix lint:styles script not matching files in deep subdirectories
oxyc
added a commit
to oxyc/sage
that referenced
this issue
Aug 20, 2017
retlehs
added a commit
that referenced
this issue
Aug 22, 2017
Followup #1950: Fix lint:styles task with cmd.exe
oxyc
added a commit
to generoi/sage
that referenced
this issue
Sep 6, 2017
* 'genero' of github.com:generoi/sage: (28 commits) move options page defaults to bedrock fix phpcs some more woocommerce defaults better defaults move out code to separate repos Update config.json (roots#1963) Add friendly-errors-webpack-plugin (roots#1961) fix sql syntax error when post has no terms Move /controllers to app, remove app/lib/Sage in readme. Controller 9.0.0-beta.4 Followup roots#1950: Fix lint:styles task with cmd.exe Change default Controller path to app/controllers Ensure to get templates filenames without path and extension. Fix lint:styles script not matching files in deep subdirectories Update helpers.php Update webpack.config.js (roots#1946) 👀 Bump sage-installer BS4 now requires Popper Bump sage-lib ...
ptrckvzn
pushed a commit
to ptrckvzn/sage
that referenced
this issue
Sep 13, 2017
* upstream/master: (45 commits) Remove get_the_posts_navigation from 404 Update config.json (roots#1963) Add friendly-errors-webpack-plugin (roots#1961) Move /controllers to app, remove app/lib/Sage in readme. Controller 9.0.0-beta.4 Followup roots#1950: Fix lint:styles task with cmd.exe Change default Controller path to app/controllers Ensure to get templates filenames without path and extension. Fix lint:styles script not matching files in deep subdirectories Update helpers.php Update webpack.config.js (roots#1946) 👀 Bump sage-installer BS4 now requires Popper Bump sage-lib Bootstrap 4 Beta, Sage 9.0.0-beta.4 Remove PHP 5.6 tests from Travis Update README.md Update sage-installer 1.1 -> 1.2 Update CHANGELOG ... # Conflicts: # package.json # resources/assets/build/postcss.config.js # resources/assets/build/webpack.config.js # resources/assets/styles/common/_global.scss # resources/assets/styles/common/_variables.scss # resources/assets/styles/components/_comments.scss # resources/assets/styles/components/_forms.scss # resources/assets/styles/components/_wp-classes.scss # resources/assets/styles/layouts/_header.scss # resources/assets/styles/main.scss # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Submit a feature request or bug report
What is the current behavior?
Currently running
npm run lint:styles
does not lint files in 2-level deep directories.What is the expected or desired behavior?
The glob pattern
/**/*.{scss,..}
should be expanded to match all files in any depth.Bug report
Please provide steps to reproduce, including full log output:
sh
bin points to a) bourne shell b) bash < 4 c) bash 4+ withextglob
disabled.mkdir resources/assets/styles/components/foo
echo "foo" > resources/assets/styles/components/foo/bar.scss
yarn run lint:styles
While as running the command manually from Bash 4:
Please describe your local environment:
OS: macOS Sierra
NPM/Node version: v8.1.0
Where did the bug happen? Development or remote servers?
Development
Is there a related Discourse thread or were any utilized (please link them)?
Not that I'm aware of.
The text was updated successfully, but these errors were encountered: