Update ConditionalTagCheck and usage docs #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing an argument to a function for ConditionalTagCheck, the argument should *not* always be an array. The function will be called wit the arguments as is and not modified. So if the function takes a string argument, keep it as a string. If it takes an array, use an array.
swalkinshaw
force-pushed
the
conditional-tag-check-args-fix
branch
from
56bd6d7 to
fe94039
Compare
retlehs
added a commit
that referenced
this pull request
Mar 3, 2015
Update ConditionalTagCheck and usage docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing an argument to a function for ConditionalTagCheck, the argument should not always be an array. The function will be called wit the arguments as is and not modified. So if the function takes a string argument, keep it as a string. If it takes an array, use an array.