watch.js/browser-sync: use dev-ip instead of hard-coding localhost #1661
Conversation
|
http being hardcoded is also going to be an issue with sites that use SSL on local dev |
|
True. It does not work with Trellis SSL set to self-signed... Tried hard-coding https with "self-signed" for testing but it did not work either. It's strange because Safari does not mind if the publicPath is relative or left to default - assets are loaded. Chrome gives an ERR_INSECURE_RESPONSE in the console for every assets loaded. |
* sage-9: (32 commits) Update dependencies, incl Bootstrap 4 alpha 3 Remove HTML comments from wrapper Fix path to stylesheet in add_editor_style Added contributing guidelines link to readme Create prototype of GitHub Issue Template using Trellis equivalent as a base Update required Node.js version Update comment for importing deps Boostrap Use shorthand syntax in main.js routes router doesn't require jQuery. use default params Fix display of theme name in Customizer Convert scripts to es6 Refactor functions.php Rework template wrapper, bring back template_part() Fix tpyo Remove unused static variable in Wrapper Fix Obj->__toString() conditional logic in wrapper Allow Obj->__toString() in template heirarchy filter Wrap templates located outside the theme Remove path.extname() check ... # Conflicts: # package.json
|
The problem seems to be the css-loader with source maps enabled. If css in inlined (when running 'npm run watch'), It will not load css assets loaded with url(...) unless the public path is absolute (more info here). The solution is to load all css assets with url-loader to inline them in the bundle or dynamically assign the public path. I'm trying the later here : ptrckvzn@d4256ae This way, What do you think of this method? |
|
@ptrckvzn lgtm 👍 |
|
I will close this and open a new PR. |
Hard-coding localhost prevented access to BrowserSync from other devices on the local network.