Refactor build routine (WIP) #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relocate webpack stuff to assets/build - Switch all js to airbnb code style - Update webpack to v2.0 (beta) - Update all other dependencies
Previously the assets manifest would use the basename of a file path as
its key when looking up a cachebusted file. This was to be consistent with
Sage 8. This change makes it so that the relative path is used instead.
To clarify, review the following example.
Before:
```
{
"main.js": "scripts/main_5f4bfc9a9f82291c6dea.js",
"main.css": "styles/main_5f4bfc9a9f82291c6dea.css",
"customizer.js": "scripts/customizer_5f4bfc9a9f82291c6dea.js"
}
```
After:
```
{
"scripts/main.js":"scripts/main_5f4bfc9a9f82291c6dea.js",
"styles/main.css":"styles/main_5f4bfc9a9f82291c6dea.css",
"scripts/customizer.js":"scripts/customizer_5f4bfc9a9f82291c6dea.js"
}
```
|
That's cool ! I'm looking forward testing and using this ! Two things (I tested no. 1, but not no. 2):
|
QWp6t
force-pushed
the
s9-refactor-build-routine
branch
from
0417907 to
65b3049
Compare
QWp6t
force-pushed
the
s9-refactor-build-routine
branch
from
65b3049 to
f6cee29
Compare
QWp6t
force-pushed
the
s9-refactor-build-routine
branch
from
35ae7f6 to
054cd83
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Apparently this is not compatible with anything lower than Node 6.x. I'll have to take care of that.
Right now this should work. You should be able to run the following commands out of the box.
npm startandnpm testare aliases fornpm run watchandnpm run lint(althoughtestcould be modified to run actual tests as well, obviously).I haven't done much testing, and the commits are a little messy. I'll likely rebase it and add some better commit messages before merging.