Allow browser versions to be configured in config.json #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QWp6t
reviewed
Jan 10, 2017
| @@ -26,6 +26,7 @@ const config = mergeWithConcat({ | |||
| watcher: !!argv.watch, | |||
| }, | |||
| watch: [], | |||
| browsers: ['last 2 versions', 'android 4', 'opera 12'], | |||
There was a problem hiding this comment.
Can you make this line:
browsers: []And add those browser versions to config.json instead?
The reason is because arrays are concatenated by mergeWithConcat().
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As sage is a starter theme it shouldn't make hardcoded assumptions about which browsers are supported. This PR allows users to override the default browser array passed to autoprefixer. It also passes this array on to cssnano to avoid stripping intentional vendor prefixes.