Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Font Awesome #1809

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Remove Font Awesome #1809

merged 2 commits into from
Jan 13, 2017

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Jan 13, 2017

font awesome was added in sage 9 mainly to provide a good example out of the box on how to add a 3rd party package

there's a few issues:

this will instead be moved to the docs

@retlehs retlehs mentioned this pull request Jan 13, 2017
1 task
@retlehs retlehs merged commit ea7323a into beta2 Jan 13, 2017
@retlehs retlehs deleted the remove-font-awesome branch January 13, 2017 19:05
@MWDelaney
Copy link
Member

MWDelaney commented Jan 13, 2017

What would be nice is good documentation on how to add it again. This and the default grid (removed in Beta 2) provided really good examples to work from especially considering that 1) "how do I add FontAwesome" is a REALLY frequent question on Discourse, and 2) Bootstrap 4 doesn't (yet?) effectively document how to use

  @include make-col-ready();
  @include media-breakpoint-up(sm) {
        ...
   }

So I frequently reference _grid.scss for the example.

These examples could be easily maintained on a page on the website, though.

retlehs added a commit that referenced this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants