Add option to select CSS framework, add Foundation as an option #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retlehs
force-pushed
the
option-to-select-css-framework
branch
from
827b922
to
cb06874
Compare
retlehs
force-pushed
the
option-to-select-css-framework
branch
from
4a41355
to
03a329e
Compare
swalkinshaw
reviewed
Jan 18, 2017
| case 0: | ||
| break; | ||
| case 1: | ||
| file_put_contents('package.json', str_replace(' "bootstrap": "^4.0.0-alpha.6",' . "\n", ' "foundation-sites": "6.3.0",' . "\n", file_get_contents('package.json'))); |
There was a problem hiding this comment.
We should turn this into a preg_replace to so we aren't specific versions in here as much as possible.
Something like:
$default_framework_pattern = '/"bootstrap": ".*"/';
file_put_contents('package.json', preg_replace($default_framework_pattern, '"foundation-sites": "6.3.0"', file_get_contents('package.json')));Also notice that this eliminates specifying whitespace
| file_put_contents('package.json', str_replace(' "bootstrap": "^4.0.0-alpha.6",' . "\n", ' "foundation-sites": "6.3.0",' . "\n", file_get_contents('package.json'))); | ||
| file_put_contents('assets/styles/main.scss', str_replace('@import "~bootstrap/scss/bootstrap";' . "\n", '@import "~foundation-sites/scss/foundation";' . "\n" . '@include foundation-everything;' . "\n", file_get_contents('assets/styles/main.scss'))); | ||
| file_put_contents('assets/scripts/main.js', str_replace('import \'bootstrap/dist/js/bootstrap\';' . "\n", 'import \'foundation-sites/dist/js/foundation\';' . "\n", file_get_contents('assets/scripts/main.js'))); | ||
| file_put_contents('assets/styles/components/_comments.scss', ''); |
There was a problem hiding this comment.
Maybe just have an array of file names to clear?
$files_to_clear = [
'assets/styles/components/_comments.scss',
'assets/styles/components/_forms.scss',
'assets/styles/components/_wp-classes.scss',
'assets/styles/layouts/_header.scss',
];
// etc
foreach($files_to_clear as $file) {
file_put_contents($file, '');
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋