Clean up page template names #1939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detailed in issue #1936 (#1936), recent changes to this filter break soberwp/controller in the specific case of providing controller data to Blades for custom page templates because WordPress stores the entire template filename (with path) as the 'name' of the template. This information is then duplicated when it runs through Sage's `App\filter_templates()` function. This commit simply checks for those redundant items and removes them if they exist, providing nice, clean names for templates, and allowing soberwp/controller to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve #1936. It does so by cleaning up the names of page templates (which, due to the way WordPress passes those names internally, end up with some duplicated content--the linked issue describes this in greater detail).