Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plugins that don't enqueue their scripts properly #1949

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Fix for plugins that don't enqueue their scripts properly #1949

merged 1 commit into from
Aug 17, 2017

Conversation

MWDelaney
Copy link
Member

This is in reference to, and closes #1857

Code credit goes entirely to @Kimers. I just made it into a PR.

@retlehs retlehs merged commit e9417b8 into roots:master Aug 17, 2017
@retlehs
Copy link
Sponsor Member

retlehs commented Aug 17, 2017

ty!

@drawcard
Copy link
Contributor

drawcard commented Aug 28, 2017

I would gleefully like to report that the recent PR takes of all the Elementor plugin compatibility errors! (eg. Slider carousel not displaying due to slick "is not a function" JS error.)

@mvazquez
Copy link

mvazquez commented Sep 23, 2017

This PR causes errors with plugins that print something directly in the wp_enqueue_scripts action. The output goes directly at the beginning of the html document.

@drawcard
Copy link
Contributor

drawcard commented Oct 3, 2017

Which plugin are you trying to use?

@mvazquez
Copy link

mvazquez commented Oct 4, 2017

This: https://wordpress.org/plugins/jquery-validation-for-contact-form-7/
But there is more plugins that echoes in wp_enqueue_scripts.

@MWDelaney
Copy link
Member Author

That's horrifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sage 9 beta - Plugin scripts not enqueued?
4 participants