Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize and enforce single quotes #2076

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Normalize and enforce single quotes #2076

merged 4 commits into from
Nov 16, 2018

Conversation

rbraunschweig
Copy link
Contributor

No description provided.

- Add quotes and semi rules to ESLint
- Fix quotes and semicolons
- Replace stylelint property in package.json with .stylelintrc.js
- Add string-quotes stylelint rule
- Fix quotes
@retlehs
Copy link
Member

retlehs commented Jun 11, 2018

thanks! can you please remove the addition of .stylelintrc.js and keep those settings in package.json?

@LeoColomb
Copy link
Contributor

.stylelintrc.js is actually a good practice. Keeping those settings in package.json make them harder to find and read, and even worst to customize locally.

By the way, in both *rc.js files, object identifiers don't need at all quotes, they are not JSON.

{
  "json": "quotes"
}
export {
  js: 'no quote'
}

🙂

@rbraunschweig
Copy link
Contributor Author

I was also under the impression that keeping our linting configs separate from package.json would lead to better maintainability. We also have separate PHP and JS linting configs, so it seems only natural that the style config is its own file too.

@LeoColomb, I contemplated leaving identifiers unquoted, but a few of them have hyphens or slashes, so I went with an all-or-nothing approach purely for consistency.

@retlehs
Copy link
Member

retlehs commented Nov 16, 2018

sorry for the wait & thank you for the PR. i updated it to remove the single quotes for styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants