UglifyJs: Change the ecma option from 8 to 5 #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
I recently had a problem with the ecma option of UglifyJs being set to
8
.One of my packages was using bn.js as a dependency and this block of code right here was compiled to
return{a,b:f,gcd:i.iushln(c)}}
and of course thea
threw anSCRIPT1003: Expected ':'
error in Internet Explorer because it doesn't support the new EcmaScript 6 Property Shorthand syntax. I had no idea what it was and how to fix it until I found this solution so that's why I am fixing it here in this repo.Solution:
To change the ecma option of UglifyJS from
8
to5
to ensure maximum compatibility with older browsers.I think it's not very safe to keep it at
8
because not all browsers are fully EcmaScript 8 and even 6 compatible yet.