Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data from controller to comments template #2100

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Add data from controller to comments template #2100

merged 4 commits into from
Sep 7, 2018

Conversation

mejta
Copy link
Contributor

@mejta mejta commented Aug 28, 2018 •
edited
Loading

  • Right now comments template is rendered without data from the controller. This pull request fixes that.
  • Filter that renders template should have PHP_INT_MAX priority.

retlehs
retlehs requested changes Aug 28, 2018
View reviewed changes
app/filters.php Outdated Show resolved Hide resolved
mmirus
mmirus reviewed Aug 31, 2018
View reviewed changes
app/filters.php Outdated Show resolved Hide resolved
@mmirus mmirus mentioned this pull request Aug 31, 2018
Closed
6 tasks
@mejta mejta mentioned this pull request Sep 3, 2018
Closed
@mmirus mmirus mentioned this pull request Sep 6, 2018
Closed
@retlehs retlehs merged commit b8c0ebc into roots:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs requested changes

@mmirus mmirus mmirus left review comments

@QWp6t QWp6t QWp6t left review comments

@mtx-z mtx-z mtx-z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mejta @retlehs @mmirus @QWp6t @mtx-z