This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Don't do active fix for CPT if no archive page
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not have an archive page.
|
thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the custom post type is set to not have an archive,
get_post_type_archive_link()returns false. When that false value is provided to theurl_compare()util function, it runs it throughtrailingslashit()which returns the string/, which is then less than helpful in the string comparisons to follow.This PR just skips
url_compare()when the CPT doesn't have an archive set. It's not able to set any class toactivethen, but that's better than setting all CPT menu items toactive