This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of wordpress 5.2.1, wp core decided to add
-wp
to their custom patched version of jquerysee: https://core.trac.wordpress.org/ticket/47020
and it doesn't look like jquery 3.x will land any time soon: https://core.trac.wordpress.org/ticket/37110
jquery is something that's still used by a whole lot of wordpress plugins, but we're going to go ahead and remove support for this feature in soil. the way that core has and continues to deal with jquery is something i'd rather not support.
recommended plugin for retaining similar functionality: https://wordpress.org/plugins/commonwp/
regarding this comment from wp core developer azaozz:
the "proper" solution is for wordpress core to not manually backport jquery patches into their custom version of jquery, and actually upgrade to a version that is ancient (3.x), but at least not prehistoric (1.x) 💋
close #226
close #227
close #225