Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Remove jQuery CDN feature #228

Merged
merged 1 commit into from
May 23, 2019
Merged

Remove jQuery CDN feature #228

merged 1 commit into from
May 23, 2019

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented May 23, 2019

as of wordpress 5.2.1, wp core decided to add -wp to their custom patched version of jquery

see: https://core.trac.wordpress.org/ticket/47020

and it doesn't look like jquery 3.x will land any time soon: https://core.trac.wordpress.org/ticket/37110

jquery is something that's still used by a whole lot of wordpress plugins, but we're going to go ahead and remove support for this feature in soil. the way that core has and continues to deal with jquery is something i'd rather not support.

recommended plugin for retaining similar functionality: https://wordpress.org/plugins/commonwp/

regarding this comment from wp core developer azaozz:

Thanks for alerting the devs of Roots Soil. The "proper" solution would be to stop loading the unpatched jQuery from a CDN, and load the patched version from WP.

the "proper" solution is for wordpress core to not manually backport jquery patches into their custom version of jquery, and actually upgrade to a version that is ancient (3.x), but at least not prehistoric (1.x) 💋

close #226
close #227
close #225

@retlehs retlehs merged commit a608821 into master May 23, 2019
@retlehs retlehs deleted the remove-jquery-cdn branch May 23, 2019 00:52
@garretthyder
Copy link

Thanks @retlehs good call. All the best

@DanielRuf
Copy link

the "proper" solution is for wordpress core to not manually backport jquery patches into their custom version of jquery, and actually upgrade to a version that is ancient (3.x), but at least not prehistoric (1.x) 💋

Hi there, I am the person who created the backported patches.

Upgrading is often not a solution as this breaks many things.

A string at the end of a version is still valid SemVer afaik.

@coliff
Copy link
Contributor

coliff commented Dec 11, 2020

Now that WordPress uses jQuery 3.5.1 perhaps the jQuery CDN feature could be re-introduced?

@strarsis
Copy link

@coliff, @retlehs: The same topic came up in the Sage 9.1 update branch PR.
Never used this feature myself, but should it be re-introduced with the current browser-, WordPress-, stack-landscape in 2021?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP 5.2.1 and the custom patched jQuery breaks the soil-jquery-cdn due to -wp in version string
5 participants