new getter function for nerd db #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevrome
reviewed
Apr 3, 2021
DESCRIPTION
Outdated
| @@ -1,7 +1,7 @@ | |||
| Package: c14bazAAR | |||
| Title: Download and Prepare C14 Dates from Different Source Databases | |||
| Description: Query different C14 date databases and apply basic data cleaning, merging and calibration steps. Currently available databases: 14cpalaeolithic, 14sea, adrac, austarch, calpal, context, emedyd, eubar, euroevol, irdd, jomon, katsianis, kiteeastafrica, medafricarbon, mesorad, pacea, palmisano, radon, radonb. | |||
| Version: 2.0.0 | |||
| Version: 2.0.1 | |||
There was a problem hiding this comment.
Why are there changes in the binary data/material_thesaurus.rda file, but apparently not in the underlying .csv file? 🤔
Running data-raw/data_prep.R generates a new .rda , does it not?
nevrome
reviewed
Apr 3, 2021
| ,nerd,Problems, | ||
| ,nerd,Species, | ||
| ,nerd,SiteID, | ||
| ,nerd,SiteType, |
There was a problem hiding this comment.
Our c14bazAAR datatype has a predefined column for sample species and type of site (https://github.com/ropensci/c14bazAAR/blob/master/data-raw/variable_definition.csv). So maybe we could map these variables as well? Or do they have a very different meaning in NERD?
There was a problem hiding this comment.
Missed those two, thanks for noticing.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for testing @nevrome