Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check up front that we have all the packages required for our formats. #1156

Closed
2 tasks done
wlandau opened this issue Jan 31, 2020 · 2 comments
Closed
2 tasks done

Comments

@wlandau
Copy link
Member

wlandau commented Jan 31, 2020

Prework

Description

If we use drake_plan(x = target(your_df(), format = "fst") and the fst package is not installed, drake throws an error at the last minute. We should check ASAP that all the packages are present for the selected formats. We should also emphasize in the docs that these packages do not come pre-installed with drake.

cc @MilesMcBain

@wlandau
Copy link
Member Author

wlandau commented Jan 31, 2020

Related: ropensci-books/drake#145

@wlandau
Copy link
Member Author

wlandau commented Feb 4, 2020

Turns out this patch makes vis_drake_graph() and friends brittle. I think those utility functions should work without formats, so I am putting this check at the very beginning of make() instead of drake_config().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant